The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: linux-afs@lists.infradead.org
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 00/13] RxRPC: Rewrite part 1
Date: Fri, 04 Mar 2016 16:37:05 +0000	[thread overview]
Message-ID: <20160304163705.31057.60831.stgit@warthog.procyon.org.uk> (raw)


Here's the first set of patches from my RxRPC rewrite, aimed at net-next.
These do some clean ups and bug fixes.  Most of the changes are small, but
there are a couple of bigger changes:

 (*) Convert call flag numbers and event numbers into enums.  Then rename
     the event numbers to all have _EV_ in their name to stop confusion.
     Fix one instance of an event bit being used instead of a flag bit.

 (*) A copy of the Rx protocol header is kept in the sk_buff private data.
     Keep this in host byte order rather than network byte order as it
     makes more sense.  A number of other fields then get converted into
     host byte order too.

     Conversion between host and network byte order is then done at the
     packet reception/generation stage.

The patches can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite

Tagged thusly:

	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
	rxrpc-rewrite-20160304

This is based on net-next/master

David
---
David Howells (13):
      rxrpc: Fix a case where a call event bit is being used as a flag bit
      rxrpc: Convert call flag and event numbers into enums
      rxrpc: Rename call events to begin RXRPC_CALL_EV_
      rxrpc: Keep the skb private record of the Rx header in host byte order
      rxrpc: The protocol family should be set to PF_RXRPC not PF_UNIX
      rxrpc: Fix defined range for /proc/sys/net/rxrpc/rx_mtu
      rxrpc: Be more selective about the types of received packets we accept
      rxrpc: Adjust some whitespace and comments
      rxrpc: Use ACCESS_ONCE() when accessing circular buffer pointers
      rxrpc: rxkad: The version number in the response should be net byte order
      rxrpc: rxkad: Casts are needed when comparing be32 values
      rxrpc: Clear the unused part of a sockaddr_rxrpc for memcmp() use
      rxrpc: Don't try to map ICMP to error as the lower layer already did that


 include/rxrpc/packet.h    |   15 +++
 net/rxrpc/af_rxrpc.c      |   39 +++-----
 net/rxrpc/ar-accept.c     |   56 +++++++-----
 net/rxrpc/ar-ack.c        |  213 ++++++++++++++++++++++-----------------------
 net/rxrpc/ar-call.c       |   84 ++++++++----------
 net/rxrpc/ar-connection.c |   83 ++++++++----------
 net/rxrpc/ar-connevent.c  |   79 ++++++++---------
 net/rxrpc/ar-error.c      |   13 ---
 net/rxrpc/ar-input.c      |  118 ++++++++++++++-----------
 net/rxrpc/ar-internal.h   |  196 ++++++++++++++++++++++++-----------------
 net/rxrpc/ar-local.c      |   29 ++++--
 net/rxrpc/ar-output.c     |   73 ++++++++++-----
 net/rxrpc/ar-peer.c       |    2 
 net/rxrpc/ar-proc.c       |   10 +-
 net/rxrpc/ar-recvmsg.c    |   20 ++--
 net/rxrpc/ar-security.c   |    6 +
 net/rxrpc/ar-skbuff.c     |    7 +
 net/rxrpc/ar-transport.c  |    1 
 net/rxrpc/rxkad.c         |  165 ++++++++++++++++++-----------------
 net/rxrpc/sysctl.c        |    2 
 20 files changed, 639 insertions(+), 572 deletions(-)

             reply	other threads:[~2016-03-04 16:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 16:37 David Howells [this message]
2016-03-04 16:37 ` [PATCH 01/13] rxrpc: Fix a case where a call event bit is being used as a flag bit David Howells
2016-03-04 16:37 ` [PATCH 02/13] rxrpc: Convert call flag and event numbers into enums David Howells
2016-03-04 16:37 ` [PATCH 03/13] rxrpc: Rename call events to begin RXRPC_CALL_EV_ David Howells
2016-03-04 16:37 ` [PATCH 04/13] rxrpc: Keep the skb private record of the Rx header in host byte order David Howells
2016-03-04 16:37 ` [PATCH 05/13] rxrpc: The protocol family should be set to PF_RXRPC not PF_UNIX David Howells
2016-03-04 16:37 ` [PATCH 06/13] rxrpc: Fix defined range for /proc/sys/net/rxrpc/rx_mtu David Howells
2016-03-04 16:37 ` [PATCH 07/13] rxrpc: Be more selective about the types of received packets we accept David Howells
2016-03-04 16:38 ` [PATCH 08/13] rxrpc: Adjust some whitespace and comments David Howells
2016-03-04 16:38 ` [PATCH 09/13] rxrpc: Use ACCESS_ONCE() when accessing circular buffer pointers David Howells
2016-03-04 16:38 ` [PATCH 10/13] rxrpc: rxkad: The version number in the response should be net byte order David Howells
2016-03-04 16:38 ` [PATCH 11/13] rxrpc: rxkad: Casts are needed when comparing be32 values David Howells
2016-03-04 16:38 ` [PATCH 12/13] rxrpc: Clear the unused part of a sockaddr_rxrpc for memcmp() use David Howells
2016-03-04 16:38 ` [PATCH 13/13] rxrpc: Don't try to map ICMP to error as the lower layer already did that David Howells
2016-03-04 22:20 ` [PATCH 00/13] RxRPC: Rewrite part 1 David Miller
2016-03-04 22:33   ` David Howells
2016-03-04 23:27     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304163705.31057.60831.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox