[PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Jean Delvare]

Hi all,

This adds hardware dependency to 3 drivers for the Technologic Systems
TS-4800 board. Thanks to these dependencies, users of other systems
will not accidentally enable these drivers.

Once again I must urge subsystem maintainers to add such dependencies
to all new drivers which needs them. The lack of such dependencies
makes distribution kernel maintainers' lives a nightmare.

[PATCH 1/3] watchdog: ts4800: add hardware dependency
[PATCH 2/3] Input: ts4800: add hardware dependency
[PATCH 3/3] irqchip/ts4800: Add hardware dependency

-- 
Jean Delvare
SUSE L3 Support

[PATCH 1/3] watchdog: ts4800: add hardware dependency

[Jean Delvare]

The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
are useless unless building a SOC_IMX51 kernel, except for build
testing purposes.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>
---
 drivers/watchdog/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.5-rc3.orig/drivers/watchdog/Kconfig	2016-02-09 08:53:37.465170476 +0100
+++ linux-4.5-rc3/drivers/watchdog/Kconfig	2016-02-09 08:53:45.001221261 +0100
@@ -468,6 +468,7 @@ config NUC900_WATCHDOG
 config TS4800_WATCHDOG
 	tristate "TS-4800 Watchdog"
 	depends on HAS_IOMEM && OF
+	depends on SOC_IMX51 || COMPILE_TEST
 	select WATCHDOG_CORE
 	select MFD_SYSCON
 	help

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH 1/3] watchdog: ts4800: add hardware dependency

[Guenter Roeck]

On 02/09/2016 02:17 AM, Jean Delvare wrote:
> The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
> are useless unless building a SOC_IMX51 kernel, except for build
> testing purposes.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Wim Van Sebroeck <wim@iguana.be>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH 1/3] watchdog: ts4800: add hardware dependency

[Wim Van Sebroeck]

Hi Jean,

> The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
> are useless unless building a SOC_IMX51 kernel, except for build
> testing purposes.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> ---
>  drivers/watchdog/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-4.5-rc3.orig/drivers/watchdog/Kconfig	2016-02-09 08:53:37.465170476 +0100
> +++ linux-4.5-rc3/drivers/watchdog/Kconfig	2016-02-09 08:53:45.001221261 +0100
> @@ -468,6 +468,7 @@ config NUC900_WATCHDOG
>  config TS4800_WATCHDOG
>  	tristate "TS-4800 Watchdog"
>  	depends on HAS_IOMEM && OF
> +	depends on SOC_IMX51 || COMPILE_TEST
>  	select WATCHDOG_CORE
>  	select MFD_SYSCON
>  	help
> 
> -- 
> Jean Delvare
> SUSE L3 Support

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.

[PATCH 2/3] Input: ts4800: add hardware dependency

[Jean Delvare]

The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
are useless unless building a SOC_IMX51 kernel, except for build
testing purposes.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.5-rc3.orig/drivers/input/touchscreen/Kconfig	2016-02-02 09:02:08.180924572 +0100
+++ linux-4.5-rc3/drivers/input/touchscreen/Kconfig	2016-02-09 08:58:50.693442294 +0100
@@ -941,6 +941,7 @@ config TOUCHSCREEN_TOUCHIT213
 config TOUCHSCREEN_TS4800
 	tristate "TS-4800 touchscreen"
 	depends on HAS_IOMEM && OF
+	depends on SOC_IMX51 || COMPILE_TEST
 	select MFD_SYSCON
 	select INPUT_POLLDEV
 	help

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH 2/3] Input: ts4800: add hardware dependency

[Dmitry Torokhov]

On Tue, Feb 09, 2016 at 11:18:47AM +0100, Jean Delvare wrote:
> The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
> are useless unless building a SOC_IMX51 kernel, except for build
> testing purposes.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>

Applied, thank you.

> Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-4.5-rc3.orig/drivers/input/touchscreen/Kconfig	2016-02-02 09:02:08.180924572 +0100
> +++ linux-4.5-rc3/drivers/input/touchscreen/Kconfig	2016-02-09 08:58:50.693442294 +0100
> @@ -941,6 +941,7 @@ config TOUCHSCREEN_TOUCHIT213
>  config TOUCHSCREEN_TS4800
>  	tristate "TS-4800 touchscreen"
>  	depends on HAS_IOMEM && OF
> +	depends on SOC_IMX51 || COMPILE_TEST
>  	select MFD_SYSCON
>  	select INPUT_POLLDEV
>  	help
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 
Dmitry

[PATCH 3/3] irqchip/ts4800: Add hardware dependency

[Jean Delvare]

The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
are useless unless building a SOC_IMX51 kernel, except for build
testing purposes.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/irqchip/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.5-rc3.orig/drivers/irqchip/Kconfig	2016-02-02 09:02:08.186924622 +0100
+++ linux-4.5-rc3/drivers/irqchip/Kconfig	2016-02-09 09:05:49.524721321 +0100
@@ -160,6 +160,7 @@ config TS4800_IRQ
 	tristate "TS-4800 IRQ controller"
 	select IRQ_DOMAIN
 	depends on HAS_IOMEM
+	depends on SOC_IMX51 || COMPILE_TEST
 	help
 	  Support for the TS-4800 FPGA IRQ controller
 

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH 3/3] irqchip/ts4800: Add hardware dependency

[Jason Cooper]

On Tue, Feb 09, 2016 at 11:19:20AM +0100, Jean Delvare wrote:
> The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
> are useless unless building a SOC_IMX51 kernel, except for build
> testing purposes.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  drivers/irqchip/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

Applied to irqchip/core.  Once we see this IP appear outside of IMX51,
we can redo the Kconfig symbols based on what we see.

thx,

Jason.

Re: [PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Guenter Roeck]

On 02/09/2016 02:15 AM, Jean Delvare wrote:
> Hi all,
>
> This adds hardware dependency to 3 drivers for the Technologic Systems
> TS-4800 board. Thanks to these dependencies, users of other systems
> will not accidentally enable these drivers.
>
> Once again I must urge subsystem maintainers to add such dependencies
> to all new drivers which needs them. The lack of such dependencies
> makes distribution kernel maintainers' lives a nightmare.
>
> [PATCH 1/3] watchdog: ts4800: add hardware dependency
> [PATCH 2/3] Input: ts4800: add hardware dependency
> [PATCH 3/3] irqchip/ts4800: Add hardware dependency
>
How about TOUCHSCREEN_TS4800 ?

Guenter

Re: [PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Jean Delvare]

Hi Guenter,

Le Tuesday 09 February 2016 à 06:28 -0800, Guenter Roeck a écrit :
> On 02/09/2016 02:15 AM, Jean Delvare wrote:
> > Hi all,
> >
> > This adds hardware dependency to 3 drivers for the Technologic Systems
> > TS-4800 board. Thanks to these dependencies, users of other systems
> > will not accidentally enable these drivers.
> >
> > Once again I must urge subsystem maintainers to add such dependencies
> > to all new drivers which needs them. The lack of such dependencies
> > makes distribution kernel maintainers' lives a nightmare.
> >
> > [PATCH 1/3] watchdog: ts4800: add hardware dependency
> > [PATCH 2/3] Input: ts4800: add hardware dependency
> > [PATCH 3/3] irqchip/ts4800: Add hardware dependency
> >
> How about TOUCHSCREEN_TS4800 ?

This is patch 2/3 above. Maybe I could make the subject line clearer
indeed.

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Damien Riegel]

Hi Jean,

On Tue, Feb 09, 2016 at 11:15:49AM +0100, Jean Delvare wrote:
> Hi all,
> 
> This adds hardware dependency to 3 drivers for the Technologic Systems
> TS-4800 board. Thanks to these dependencies, users of other systems
> will not accidentally enable these drivers.

These drivers are for IPs implemented in an FPGA. For now it is true
that they are used only on one board with an iMX.51 but this is not a
strong dependency and it might change in the future if Technologic
Systems decide to reuse these IPs on boards based on different SoCs.

As the FPGA and the SoC are two separate chips, I don't know how such
dependency should be expressed in kconfig.

Thanks,
Damien

Re: [PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Guenter Roeck]

On 02/09/2016 07:08 AM, Damien Riegel wrote:
> Hi Jean,
>
> On Tue, Feb 09, 2016 at 11:15:49AM +0100, Jean Delvare wrote:
>> Hi all,
>>
>> This adds hardware dependency to 3 drivers for the Technologic Systems
>> TS-4800 board. Thanks to these dependencies, users of other systems
>> will not accidentally enable these drivers.
>
> These drivers are for IPs implemented in an FPGA. For now it is true
> that they are used only on one board with an iMX.51 but this is not a
> strong dependency and it might change in the future if Technologic
> Systems decide to reuse these IPs on boards based on different SoCs.
>
> As the FPGA and the SoC are two separate chips, I don't know how such
> dependency should be expressed in kconfig.
>

You could add a Kconfig option for the FPGA, which currently depends
on the SoC.

Guenter

Re: [PATCH 0/3] Add hardware dependency to TS-4800 board drivers

[Jean Delvare]

Hi Damien,

Le Tuesday 09 February 2016 à 10:08 -0500, Damien Riegel a écrit :
> On Tue, Feb 09, 2016 at 11:15:49AM +0100, Jean Delvare wrote:
> > This adds hardware dependency to 3 drivers for the Technologic Systems
> > TS-4800 board. Thanks to these dependencies, users of other systems
> > will not accidentally enable these drivers.
> 
> These drivers are for IPs implemented in an FPGA. For now it is true
> that they are used only on one board with an iMX.51 but this is not a
> strong dependency and it might change in the future if Technologic
> Systems decide to reuse these IPs on boards based on different SoCs.

When this happens, we can update the dependency accordingly, this is not
a problem.

> As the FPGA and the SoC are two separate chips, I don't know how such
> dependency should be expressed in kconfig.

The way I did ;-)

These dependencies just tell where the hardware is being used at the
moment. They do not imply that the same hardware can't be reused later
on another board. In which case we can extend the dependency (e.g.
adding another SOC family), or broaden it (e.g. "depends on ARM") or
drop it altogether if the piece of hardware in question has taken over
the world meanwhile.

But my experience is that a piece of hardware developed for i.MX has
little chances to be found on a PowerPC system, even 5 years later.

-- 
Jean Delvare
SUSE L3 Support