From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760411AbcCEC23 (ORCPT ); Fri, 4 Mar 2016 21:28:29 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34725 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760020AbcCEC21 (ORCPT ); Fri, 4 Mar 2016 21:28:27 -0500 Date: Fri, 4 Mar 2016 18:28:23 -0800 From: Brian Norris To: Roger Quadros Cc: tony@atomide.com, dwmw2@infradead.org, ezequiel@vanguardiasur.com.ar, javier@dowhile0.org, fcooper@ti.com, nsekhar@ti.com, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support Message-ID: <20160305022823.GO55664@google.com> References: <1455916548-3441-1-git-send-email-rogerq@ti.com> <1455916548-3441-10-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455916548-3441-10-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, another small thing I noticed. On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote: > Move NAND specific device tree parsing to NAND driver. > > The NAND controller node must have a compatible id, register space > resource and interrupt resource. > > Signed-off-by: Roger Quadros > --- [...] > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index 9e99199..0a637c4 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -177,10 +178,11 @@ struct omap_nand_info { > struct gpmc_nand_regs reg; > struct gpmc_nand_ops *ops; > /* generated at runtime depending on ECC algorithm and layout selected */ ^^^ I don't think that comment describes the following line. You probably meant to delete this one? > + bool flash_bbt; > + /* generated at runtime depending on ECC algorithm and layout */ > struct nand_ecclayout oobinfo; > /* fields specific for BCHx_HW ECC scheme */ > struct device *elm_dev; > - struct device_node *of_node; > }; > > static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd) [...] Brian