From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode
Date: Sat, 5 Mar 2016 19:17:22 +0100 [thread overview]
Message-ID: <20160305181722.GA17746@krava.redhat.com> (raw)
In-Reply-To: <1457103582-28396-4-git-send-email-namhyung@kernel.org>
On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote:
SNIP
> @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct hists *hists,
> struct hist_entry *he)
> {
> struct perf_hpp_fmt *fmt;
> + struct perf_hpp_list_node *node;
> struct hist_entry *new_he = NULL;
> struct hist_entry *parent = NULL;
> int depth = 0;
> int ret = 0;
>
> - hists__for_each_sort_list(hists, fmt) {
> - if (!perf_hpp__is_sort_entry(fmt) &&
> - !perf_hpp__is_dynamic_entry(fmt))
> - continue;
> - if (perf_hpp__should_skip(fmt, hists))
> + list_for_each_entry(node, &hists->hpp_formats, list) {
> + bool skip = false;
> +
> + perf_hpp_list__for_each_sort_list(&node->hpp, fmt) {
> + if (!perf_hpp__is_sort_entry(fmt) &&
> + !perf_hpp__is_dynamic_entry(fmt))
> + skip = true;
> + if (perf_hpp__should_skip(fmt, hists))
> + skip = true;
> + if (skip)
> + break;
could we add skip bool into node and initialize it gradually in add_hierarchy_fmt?
jirka
next prev parent reply other threads:[~2016-03-05 18:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 14:59 [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v2) Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 1/8] perf tools: Add level field to struct perf_hpp_fmt Namhyung Kim
2016-03-08 10:32 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim
2016-03-04 21:58 ` Arnaldo Carvalho de Melo
2016-03-04 21:59 ` Arnaldo Carvalho de Melo
2016-03-07 12:43 ` Namhyung Kim
2016-03-07 13:57 ` Namhyung Kim
2016-03-06 18:43 ` Jiri Olsa
2016-03-07 12:59 ` Namhyung Kim
2016-03-07 13:15 ` Jiri Olsa
2016-03-04 14:59 ` [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode Namhyung Kim
2016-03-05 18:17 ` Jiri Olsa [this message]
2016-03-07 12:42 ` Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 4/8] perf tools: Support multiple sort keys in a hierarchy level Namhyung Kim
2016-03-04 21:48 ` Arnaldo Carvalho de Melo
2016-03-07 12:38 ` Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 5/8] perf tools: Fix indent for multiple hierarchy sort key Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 6/8] perf report: Use hierarchy hpp list on stdio Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 7/8] perf hists browser: Use hierarchy hpp list Namhyung Kim
2016-03-04 14:59 ` [PATCH v2 8/8] perf report: Use hierarchy hpp list on gtk Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305181722.GA17746@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).