From: Lee Jones <lee.jones@linaro.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mailbox: sti: fix check of error code returned by devm_ioremap_resource()
Date: Sun, 6 Mar 2016 10:01:00 +0700 [thread overview]
Message-ID: <20160306030100.GA3326@x1> (raw)
In-Reply-To: <1457227287-3039-1-git-send-email-vz@mleia.com>
On Sun, 06 Mar 2016, Vladimir Zapolskiy wrote:
> The change fixes potential oops while accessing iomem on invalid
> address, if devm_ioremap_resource() fails due to some reason.
>
> The devm_ioremap_resource() function returns ERR_PTR() and never
> returns NULL, which makes useless a following check for NULL.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Fixes: 9ef4546cbd7e ("mailbox: Add support for ST's Mailbox IP")
> ---
> drivers/mailbox/mailbox-sti.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
> index 2394cfe..a334db5 100644
> --- a/drivers/mailbox/mailbox-sti.c
> +++ b/drivers/mailbox/mailbox-sti.c
> @@ -430,8 +430,8 @@ static int sti_mbox_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> mdev->base = devm_ioremap_resource(&pdev->dev, res);
> - if (!mdev->base)
> - return -ENOMEM;
> + if (IS_ERR(mdev->base))
> + return PTR_ERR(mdev->base);
>
> ret = of_property_read_string(np, "mbox-name", &mdev->name);
> if (ret)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-03-06 3:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 1:21 [PATCH] mailbox: sti: fix check of error code returned by devm_ioremap_resource() Vladimir Zapolskiy
2016-03-06 3:01 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306030100.GA3326@x1 \
--to=lee.jones@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox