From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbcCFMGW (ORCPT ); Sun, 6 Mar 2016 07:06:22 -0500 Received: from sauhun.de ([89.238.76.85]:56092 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbcCFMGM (ORCPT ); Sun, 6 Mar 2016 07:06:12 -0500 Date: Sun, 6 Mar 2016 13:06:00 +0100 From: Wolfram Sang To: Greg KH Cc: Andrew Lunn , srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, broonie@kernel.org, vz@mleia.com, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com Subject: Re: [PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM Message-ID: <20160306120559.GA1396@katana> References: <1456516764-1456-1-git-send-email-andrew@lunn.ch> <20160302005640.GA32114@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline In-Reply-To: <20160302005640.GA32114@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 02, 2016 at 12:56:42AM +0000, Greg KH wrote: > On Fri, Feb 26, 2016 at 08:59:17PM +0100, Andrew Lunn wrote: > > This patch set converts the old EEPROM drivers in driver/misc/eeprom to > > use the NVMEM framework. These drivers export there content in /sys as > > read only to root, since the EEPROM may contain sensitive information. > > So the first patch adds a flag so the NVMEM framework will create its > > file in /sys as root read only. > >=20 > > To keep backwards compatibility with these older drivers, the contents > > of the EEPROM must be exports in sysfs in a file called eeprom in the > > devices node in sys, where as the NVMEM places them under class/nvmem. > > So add this optional backwards compatible to the framework, again > > using a flag. > >=20 > > Then convert the at24, at25 and 93xx46 by adding regmap support, > > removing each drivers own /sys code and registering with the NVMEM > > framework. > >=20 > > Lastly, the old memory accessor mechanism has been replaced with the > > nvmem equivalent. >=20 > Nice job, all now queue up. Yes, really. Pity I didn't have the time to review the at24-to-nvmem changes as much as I hoped for. But it will be good in the end. I am really thankful that you made the effort to convert this hardly used memory_accessor thing and convert it into the more widely used nvmem mechanism. And clean up the unneeded bits afterwards. Always nice to see such attitude :) Thanks, Wolfram --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW3B0nAAoJEBQN5MwUoCm2rG4QAKe6vKL2u9z5JwfZjyLjZCHi 06Cd1u2LR93popdaDb/yjB63YrmoRUjjmZWeQa1Jiabs4SK0dv+arI+zWq+0kuGH RJCuX8RNTWt1I5CCq/c+4StRDFabZ9wv0klKkw7XMx4lp9GcdYngFUYFOn0Uf2tc NwGoFZHK5Pn4ePUNTzji/xvAeHdMVloC2UbTAgNHvFWc4sLLiHgx6xWvOsEHNeDC F9I+wD9L6jSboByv0CqmTq0Tc20B8vehYiGzWG1eKILKQKQsVdKMZdb2/Vv08Iuz 6UR8yo6SzHDrzAv8vbTRXAjkOvG7l9VqBqyLkthvBasKBno8VlChT86VccWOz4VW CmjMqVAhYD1vGlNdFuFRd6aeMtxHfp38dzJT21iiFfWJCyH7m+D3cvS63ZPrjQ8e YzQzPPBluJAPM/PfjYDgAecZMluJ6P/L1RsER2eUEXTV7n33WxbjU10OfUkR5Cyf Ga+cnIw9JIrTn0+9zvBA7pqV0Rwd62n8/dKo+7k2+d26bC5QFBALMmaZHnyGaSgB nqnssz2nmg9hyumW/7wGqtPLm17G8fo/W/1xvVu9OTOx8Kavv8XJMNPnPKbv8r7r DkWgQgvQKza71cTtqSqwVAhMswE4Sua0EQG2hblKnZ8m667yXalHMfyLmCjQHHu1 3p4O3tR16wZGxOcZlggw =37Ah -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--