From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbcCGTtA (ORCPT ); Mon, 7 Mar 2016 14:49:00 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:53512 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbcCGTst (ORCPT ); Mon, 7 Mar 2016 14:48:49 -0500 Date: Mon, 07 Mar 2016 14:48:46 -0500 (EST) Message-Id: <20160307.144846.1271615479587219087.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, hannes@stressinduktion.org, kafai@fb.com Subject: Re: [PATCH net-next 2/3] ipv6: per netns fib6 walkers From: David Miller In-Reply-To: <6df8e224d6337b658a097ac87e72e1467cddf13d.1457085016.git.mkubecek@suse.cz> References: <6df8e224d6337b658a097ac87e72e1467cddf13d.1457085016.git.mkubecek@suse.cz> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Mar 2016 11:48:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Fri, 4 Mar 2016 11:59:25 +0100 (CET) > @@ -1978,6 +1980,12 @@ static int ipv6_route_yield(struct fib6_walker *w) > > static void ipv6_route_seq_setup_walk(struct ipv6_route_iter *iter) > { > +#ifdef CONFIG_NET_NS > + struct net *net = iter->p.net; > +#else > + struct net *net = &init_net; > +#endif Please use read_pnet(), it exists so that we don't need to do ugly CPP stuff like this in *.c files. Thanks.