linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc: arve@android.com, riandrews@android.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Fixed coding style issues reported by checkpatch
Date: Sun, 6 Mar 2016 17:21:08 -0800	[thread overview]
Message-ID: <20160307012108.GA1642@kroah.com> (raw)
In-Reply-To: <1457292633-3058-1-git-send-email-saiyamdoshi.in@gmail.com>

On Mon, Mar 07, 2016 at 01:00:33AM +0530, Saiyam Doshi wrote:
> List of modified files with comment,
> lowmemorykiller.c: Added blank line after array declaration
> sync.h: Added comment for spinlock_t definition,
>         Fixed parentheses alignment in function declaration
> sync_debug.c: Removed unnecessary braces for single statement block
> timed_gpio.c: Added comment for spinlock_t definition

You need to do only one thing per patch, please split this up into
multiple patches.

Also verify that these are all really needed, please always work against
linux-next, not Linus's kernel tree.

thanks,

greg k-h

  reply	other threads:[~2016-03-07  1:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 19:30 [PATCH 1/1] staging: android: Fixed coding style issues reported by checkpatch Saiyam Doshi
2016-03-07  1:21 ` Greg KH [this message]
2016-03-08 20:25   ` Saiyam Doshi
2016-03-11 21:57     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307012108.GA1642@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=saiyamdoshi.in@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).