From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio
Date: Mon, 7 Mar 2016 15:08:00 -0300 [thread overview]
Message-ID: <20160307180800.GA21297@kernel.org> (raw)
In-Reply-To: <20160307180604.GH3604@kernel.org>
Em Mon, Mar 07, 2016 at 03:06:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Mar 07, 2016 at 11:35:06PM +0900, Namhyung Kim escreveu:
> > Now hpp formats are linked using perf_hpp_list_node when hierarchy is
> > enabled. Use this info to print entries with multiple sort keys in a
> > single hierarchy properly.
> >
> > For example, the below example shows using 4 sort keys with 2 levels.
> >
> > $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}' \
> > --percent-limit 1 -i perf.data.sched
> > ...
> > # Overhead prev_pid+prev_comm / next_pid+next_comm
> > # ........... .......................................
> > #
>
> Ok, this one addresses my previous comment, I think the next one will do it for
> the TUI, good. :-)
>
>
> -# Overhead prev_pid / prev_comm / next_pid / next_comm
> -# ........... ...........................................
> +# Overhead prev_pid+prev_comm / next_pid+next_comm
> +# ........... .......................................
It ends up adding an extra space to the other cases, harmless, I guess:
@@ -68,7 +68,7 @@
# Samples: 1K of event 'sched:sched_stat_sleep'
# Event count (approx.): 0
#
-# Overhead
+# Overhead
........
#
Do you test like:
perf report ... > /tmp/before
make
perf report ... > /tmp/after
diff /tmp/before /tmp/after
?
next prev parent reply other threads:[~2016-03-07 18:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 14:35 [PATCHSET 0/7] perf tools: Support multiple keys in a single hierarchy level (v3) Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 1/7] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim
2016-03-08 10:32 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 2/7] perf tools: Use own hpp_list for hierarchy mode Namhyung Kim
2016-03-08 10:33 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 3/7] perf tools: Support multiple sort keys in a hierarchy level Namhyung Kim
2016-03-07 17:58 ` Arnaldo Carvalho de Melo
2016-03-08 10:33 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 4/7] perf tools: Fix indent for multiple hierarchy sort key Namhyung Kim
2016-03-08 10:34 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio Namhyung Kim
2016-03-07 18:06 ` Arnaldo Carvalho de Melo
2016-03-07 18:08 ` Arnaldo Carvalho de Melo [this message]
2016-03-08 10:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 6/7] perf hists browser: Use hierarchy hpp list Namhyung Kim
2016-03-08 10:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-03-07 14:35 ` [PATCH v3 7/7] perf report: Use hierarchy hpp list on gtk Namhyung Kim
2016-03-08 10:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307180800.GA21297@kernel.org \
--to=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).