From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753369AbcCGSIO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 13:08:14 -0500
Received: from mail.kernel.org ([198.145.29.136]:43812 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752285AbcCGSIK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 13:08:10 -0500
Date: Mon, 7 Mar 2016 15:08:00 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio
Message-ID: <20160307180800.GA21297@kernel.org>
References: <1457361308-514-1-git-send-email-namhyung@kernel.org>
 <1457361308-514-6-git-send-email-namhyung@kernel.org>
 <20160307180604.GH3604@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160307180604.GH3604@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Mar 07, 2016 at 03:06:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Mar 07, 2016 at 11:35:06PM +0900, Namhyung Kim escreveu:
> > Now hpp formats are linked using perf_hpp_list_node when hierarchy is
> > enabled.  Use this info to print entries with multiple sort keys in a
> > single hierarchy properly.
> > 
> > For example, the below example shows using 4 sort keys with 2 levels.
> > 
> >   $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}' \
> >    --percent-limit 1 -i perf.data.sched
> >   ...
> >   #    Overhead  prev_pid+prev_comm / next_pid+next_comm
> >   # ...........  .......................................
> >   #
> 
> Ok, this one addresses my previous comment, I think the next one will do it for
> the TUI, good. :-)
> 
> 
> -#    Overhead  prev_pid / prev_comm / next_pid / next_comm
> -# ...........  ...........................................
> +#    Overhead  prev_pid+prev_comm / next_pid+next_comm
> +# ...........  .......................................

It ends up adding an extra space to the other cases, harmless, I guess:

@@ -68,7 +68,7 @@
 # Samples: 1K of event 'sched:sched_stat_sleep'
 # Event count (approx.): 0
 #
-# Overhead
+# Overhead  
  ........
 #

Do you test like:

   perf report ... > /tmp/before
   make
   perf report ... > /tmp/after
   diff /tmp/before /tmp/after

?