From: Bjorn Helgaas <helgaas@kernel.org>
To: Nicolai Stange <nicstange@gmail.com>
Cc: Michal Simek <monstr@monstr.eu>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Takashi Iwai <tiwai@suse.de>, Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Yijing Wang <wangyijing@huawei.com>,
Yinghai Lu <yinghai@kernel.org>,
kbuild test robot <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/microblaze: export isa_io_base to modules
Date: Mon, 7 Mar 2016 14:32:15 -0600 [thread overview]
Message-ID: <20160307203215.GA26149@localhost> (raw)
In-Reply-To: <1457378964-9865-1-git-send-email-nicstange@gmail.com>
On Mon, Mar 07, 2016 at 08:29:24PM +0100, Nicolai Stange wrote:
> As discovered by the kbuild test robot, an allmodconfig build on
> microblaze bails out with
>
> ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
> [... plus dozens more throughout the tree]
>
> Export isa_io_base to modules by means of EXPORT_SYMBOL().
>
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Michal, this was sent to you, so I assume you'll handle it. Let me
know if you want me to do anything else with it.
> ---
> arch/microblaze/pci/pci-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index ae838ed..fba7a46 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */
> resource_size_t isa_mem_base;
>
> unsigned long isa_io_base;
> +EXPORT_SYMBOL(isa_io_base);
> +
> static int pci_bus_count;
>
> struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
> --
> 2.7.2
>
prev parent reply other threads:[~2016-03-07 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 19:29 [PATCH] arch/microblaze: export isa_io_base to modules Nicolai Stange
2016-03-07 20:32 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307203215.GA26149@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=monstr@monstr.eu \
--cc=nicstange@gmail.com \
--cc=tiwai@suse.de \
--cc=tomi.valkeinen@ti.com \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox