From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753768AbcCHEME (ORCPT ); Mon, 7 Mar 2016 23:12:04 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34937 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbcCHELz (ORCPT ); Mon, 7 Mar 2016 23:11:55 -0500 Date: Tue, 8 Mar 2016 11:11:44 +0700 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andi Shyti , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Laxman Dewangan Subject: Re: [PATCH 3/4] mfd: max77686: Allow driver to be built as a module Message-ID: <20160308041144.GB13692@x1> References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> <1455251419-8919-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455251419-8919-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2016, Javier Martinez Canillas wrote: > The driver's Kconfig symbol is a boolean but nothing prevents the driver > to be built as a module instead of built-in. It is true that most system > integrators will choose the latter but the config should not restrict it. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 6c4ebd9f4cb6..005ace26230e 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -493,8 +493,8 @@ config MFD_MAX14577 > of the device. > > config MFD_MAX77686 > - bool "Maxim Semiconductor MAX77686/802 PMIC Support" > - depends on I2C=y > + tristate "Maxim Semiconductor MAX77686/802 PMIC Support" > + depends on I2C > depends on OF > select MFD_CORE > select REGMAP_I2C -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog