From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753890AbcCHEYX (ORCPT ); Mon, 7 Mar 2016 23:24:23 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35870 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753500AbcCHEYP (ORCPT ); Mon, 7 Mar 2016 23:24:15 -0500 Date: Tue, 8 Mar 2016 11:24:09 +0700 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andi Shyti , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Laxman Dewangan Subject: Re: [PATCH 4/4] mfd: max77686: Export OF module alias information Message-ID: <20160308042409.GE13692@x1> References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> <1455251419-8919-5-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455251419-8919-5-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2016, Javier Martinez Canillas wrote: > When the device is registered via OF, the OF table is used to match the > driver instead of the I2C device ID table but the entries in the latter > are used as aliasses to load the module if the driver was not built-in. > > This is because the I2C core always reports an I2C module alias instead > of an OF one but that could change so it is better to always export it. I do have a set which changes this behaviour. Annoyingly it is still not applied. :( > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/max77686.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 2f563d0f83cc..b1ed9ed0828c 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -204,6 +204,7 @@ static const struct of_device_id max77686_pmic_dt_match[] = { > }, > { }, > }; > +MODULE_DEVICE_TABLE(of, max77686_pmic_dt_match); > > static int max77686_i2c_probe(struct i2c_client *i2c, > const struct i2c_device_id *id) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog