From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table
Date: Tue, 8 Mar 2016 11:24:48 +0700 [thread overview]
Message-ID: <20160308042448.GF13692@x1> (raw)
In-Reply-To: <1455251419-8919-2-git-send-email-javier@osg.samsung.com>
On Fri, 12 Feb 2016, Javier Martinez Canillas wrote:
> The max77686 MFD driver supports both the Maxim 77686 and Maxim 77802
> PMICs but only the OF device table contains entries for both devices.
>
> The max77802 entry is missing in the I2C device ID table which isn't
> a problem currently since the driver only supports DT but it will be
> needed if the driver is changed to be built as a module since the I2C
> core always reports a I2C modalias uevent so auto-load will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/max77686.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index d959ebbb2194..1f30c97d6d4e 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -345,6 +345,7 @@ static int max77686_i2c_remove(struct i2c_client *i2c)
>
> static const struct i2c_device_id max77686_i2c_id[] = {
> { "max77686", TYPE_MAX77686 },
> + { "max77802", TYPE_MAX77802 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, max77686_i2c_id);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-08 4:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 4:30 [PATCH 0/4] mfd: max77686: Allow the driver to be built as a module Javier Martinez Canillas
2016-02-12 4:30 ` [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table Javier Martinez Canillas
2016-02-15 5:21 ` Krzysztof Kozlowski
2016-03-08 4:24 ` Lee Jones [this message]
2016-02-12 4:30 ` [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Javier Martinez Canillas
2016-02-15 6:54 ` Krzysztof Kozlowski
2016-02-15 8:21 ` Lee Jones
2016-02-15 15:21 ` Javier Martinez Canillas
2016-02-15 23:20 ` Krzysztof Kozlowski
2016-02-16 20:45 ` Javier Martinez Canillas
2016-02-17 7:49 ` Krzysztof Kozlowski
2016-02-17 18:38 ` Javier Martinez Canillas
2016-02-17 9:27 ` Marek Szyprowski
2016-02-17 9:34 ` Krzysztof Kozlowski
2016-02-12 4:30 ` [PATCH 3/4] mfd: max77686: Allow driver to be built as a module Javier Martinez Canillas
2016-03-08 4:11 ` Lee Jones
2016-02-12 4:30 ` [PATCH 4/4] mfd: max77686: Export OF module alias information Javier Martinez Canillas
2016-02-15 6:55 ` Krzysztof Kozlowski
2016-03-08 4:24 ` Lee Jones
2016-02-15 7:04 ` [PATCH 0/4] mfd: max77686: Allow the driver to be built as a module Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308042448.GF13692@x1 \
--to=lee.jones@linaro.org \
--cc=andi.shyti@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).