From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932251AbcCHEZB (ORCPT ); Mon, 7 Mar 2016 23:25:01 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35158 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbcCHEYx (ORCPT ); Mon, 7 Mar 2016 23:24:53 -0500 Date: Tue, 8 Mar 2016 11:24:48 +0700 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andi Shyti , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Laxman Dewangan Subject: Re: [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table Message-ID: <20160308042448.GF13692@x1> References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> <1455251419-8919-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455251419-8919-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2016, Javier Martinez Canillas wrote: > The max77686 MFD driver supports both the Maxim 77686 and Maxim 77802 > PMICs but only the OF device table contains entries for both devices. > > The max77802 entry is missing in the I2C device ID table which isn't > a problem currently since the driver only supports DT but it will be > needed if the driver is changed to be built as a module since the I2C > core always reports a I2C modalias uevent so auto-load will not work. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/max77686.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index d959ebbb2194..1f30c97d6d4e 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -345,6 +345,7 @@ static int max77686_i2c_remove(struct i2c_client *i2c) > > static const struct i2c_device_id max77686_i2c_id[] = { > { "max77686", TYPE_MAX77686 }, > + { "max77802", TYPE_MAX77802 }, > { } > }; > MODULE_DEVICE_TABLE(i2c, max77686_i2c_id); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog