From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbcCHHzI (ORCPT ); Tue, 8 Mar 2016 02:55:08 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34165 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754129AbcCHHy2 (ORCPT ); Tue, 8 Mar 2016 02:54:28 -0500 Date: Tue, 8 Mar 2016 14:54:21 +0700 From: Lee Jones To: Andy Shevchenko Cc: Andy Shevchenko , "linux-kernel@vger.kernel.org" , Heikki Krogerus , Mika Westerberg Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: save register context on suspend Message-ID: <20160308075421.GL13692@x1> References: <1453808546-10897-1-git-send-email-andriy.shevchenko@linux.intel.com> <20160308044823.GJ13692@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Mar 2016, Andy Shevchenko wrote: > On Tue, Mar 8, 2016 at 6:48 AM, Lee Jones wrote: > > On Tue, 26 Jan 2016, Andy Shevchenko wrote: > > > >> From: Heikki Krogerus > >> > >> All configurations are lost and the registers will have > >> default values when the hardware is suspended and resumed, > >> so saving the private register space context on suspend, and > >> restoring it on resume. > >> > >> Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices) > > > > I'd say this sumbission is more of a functional extention than a > > bug-fix. No real need for this statement. > > But we would like send it later to stable@ to have this back ported. Yes, I see. Although, as it "fixes" a first submission, my personal preference would be a: Cc: stable@vger.kernel.org # v4.{whatever} .. tag instead. > >> Signed-off-by: Heikki Krogerus > >> Signed-off-by: Mika Westerberg > > > > Did it really take 2 of you to write this patch? > > It's probably my mistake, since I took this one from Mika's tree and > kept his SoB. No problem. Please omit his SoB when upstreaming patches from BSP trees. > >> Signed-off-by: Andy Shevchenko > >> --- > >> drivers/mfd/intel-lpss.c | 19 ++++++++++++++++++- > >> 1 file changed, 18 insertions(+), 1 deletion(-) > > > > Code looks okay though: > > Acked-by: Lee Jones > > Thanks. > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog