From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752813AbcCHNXz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Mar 2016 08:23:55 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33751 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752273AbcCHNXo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Mar 2016 08:23:44 -0500
Date: Tue, 8 Mar 2016 14:23:40 +0100
From: Ingo Molnar <mingo@kernel.org>
To: acme@redhat.com, hpa@zytor.com, jolsa@kernel.org, a.p.zijlstra@chello.nl,
        tglx@linutronix.de, dsahern@gmail.com, namhyung@kernel.org,
        jolsa@redhat.com, linux-kernel@vger.kernel.org, mingo@redhat.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf tools: Fix locale handling in pmu parsing
Message-ID: <20160308132340.GA7914@gmail.com>
References: <20160303095348.GA24511@krava.redhat.com>
 <tip-f9a5978ac4ede901fa73d7c28ae1c5d89bc2a46a@git.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tip-f9a5978ac4ede901fa73d7c28ae1c5d89bc2a46a@git.kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* tip-bot for Jiri Olsa <tipbot@zytor.com> wrote:

> @@ -135,6 +146,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
>  	/* restore locale */
>  	setlocale(LC_NUMERIC, lc);
>  
> +	free((char *) lc);
> +

Btw., minor side note: why does 'lc' have to be case to 'char *'?

In the kernel kfree() takes 'const void *':

  include/linux/slab.h:void kfree(const void *);

which will accept all pointer types. That avoids unnecessary and fragile type 
casts.

Thanks,

	Ingo