From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933420AbcCHQ4k (ORCPT ); Tue, 8 Mar 2016 11:56:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932998AbcCHQzM (ORCPT ); Tue, 8 Mar 2016 11:55:12 -0500 Date: Tue, 8 Mar 2016 18:55:02 +0200 From: "Michael S. Tsirkin" To: James Hogan Cc: Ralf Baechle , Michal Marek , Andi Kleen , Geert Uytterhoeven , linux-mips@linux-mips.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ld-version: Fix awk regex compile failure Message-ID: <20160308185430-mutt-send-email-mst@redhat.com> References: <1457455673-12219-1-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457455673-12219-1-git-send-email-james.hogan@imgtec.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2016 at 04:47:53PM +0000, James Hogan wrote: > The ld-version.sh script fails on some versions of awk with the > following error, resulting in build failures for MIPS: > > awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(') > > This is due to the regular expression ".*)", meant to strip off the > beginning of the ld version string up to the close bracket, however > brackets have a meaning in regular expressions, so lets escape it so > that awk doesn't expect a corresponding open bracket. > > Fixes: ccbef1674a15 ("Kbuild, lto: add ld-version and ld-ifversion ...") > Reported-by: Geert Uytterhoeven > Signed-off-by: James Hogan > Cc: Ralf Baechle > Cc: Michal Marek > Cc: Andi Kleen > Cc: "Michael S. Tsirkin" > Cc: linux-mips@linux-mips.org > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: # 4.4.x- Tested-by: Michael S. Tsirkin Acked-by: Michael S. Tsirkin > --- > I've only tested this with GNU Awk 4.0.2, which seems a bit more > lenient than whatever version of awk Geert's build machine is using. > > I'd appreciated if somebody experiencing the error could give this patch > a spin to check it fixes it. > --- > scripts/ld-version.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/ld-version.sh b/scripts/ld-version.sh > index d154f0877fd8..7bfe9fa1c8dc 100755 > --- a/scripts/ld-version.sh > +++ b/scripts/ld-version.sh > @@ -1,7 +1,7 @@ > #!/usr/bin/awk -f > # extract linker version number from stdin and turn into single number > { > - gsub(".*)", ""); > + gsub(".*\\)", ""); > gsub(".*version ", ""); > gsub("-.*", ""); > split($1,a, "."); > -- > 2.4.10