From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753161AbcCIJsN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Mar 2016 04:48:13 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34154 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752635AbcCIJsE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Mar 2016 04:48:04 -0500
Date: Wed, 9 Mar 2016 10:47:59 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        live-patching@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
        Chris J Arges <chris.j.arges@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jiri Slaby <jslaby@suse.cz>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 09/11] tools/objtool: Copy hashtable.h into tools
 directory
Message-ID: <20160309094759.GA11911@gmail.com>
References: <20160308154909.GA20956@gmail.com>
 <cover.1457502970.git.jpoimboe@redhat.com>
 <be3bef72f6540d8a510515408119d968a0e18179.1457502970.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <be3bef72f6540d8a510515408119d968a0e18179.1457502970.git.jpoimboe@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> Copy hashtable.h from include/linux/tools.h.  It's needed by objtool in
> the next patch in the series.
> 
> Add some includes that it needs, and remove references to
> kernel-specific features like RCU and __read_mostly.
> 
> Also change some if its dependency headers' includes to use quotes
> instead of brackets so gcc can find them.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/include/asm-generic/bitops/__fls.h |   2 +-
>  tools/include/asm-generic/bitops/fls.h   |   2 +-
>  tools/include/asm-generic/bitops/fls64.h |   2 +-
>  tools/include/linux/hashtable.h          | 152 +++++++++++++++++++++++++++++++
>  4 files changed, 155 insertions(+), 3 deletions(-)

So it would be nice to also add a build time warning if the 'upstream' copy of 
hashtable.h deviates from the tooling file.

Just like you are already doing it for other files:

objtool/Makefile:       diff -I'^#include' arch/x86/insn/insn.c ../../arch/x86/lib/insn.c >/dev/null && \

Btw., eventually we might want to factor out such duplication into a single place 
in tools/lib/ or so, to only have a 'master copy' (upstream kernel source), and 
the tooling copy.

Thanks,

	Ingo