From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932402AbcCIMla (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Mar 2016 07:41:30 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35579 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753494AbcCIMlW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Mar 2016 07:41:22 -0500
Date: Wed, 9 Mar 2016 13:41:17 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: tim.gardner@canonical.com, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early:
 Squelch frame size warning
Message-ID: <20160309124117.GA26069@gmail.com>
References: <1452178799-20878-1-git-send-email-tim.gardner@canonical.com>
 <1452178799-20878-2-git-send-email-tim.gardner@canonical.com>
 <20160118101004.GC12644@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160118101004.GC12644@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Jan 07, 2016 at 07:59:56AM -0700, tim.gardner@canonical.com wrote:
> > From: Tim Gardner <tim.gardner@canonical.com>
> > 
> > arch/x86/kernel/cpu/microcode/intel.c: In function 'save_mc_for_early':
> > arch/x86/kernel/cpu/microcode/intel.c:516:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Ok, so this looks like a 32-bit warning to me.
> 
> Hmm, so, on the one hand we do have:
> 
> $ git grep CONFIG_FRAME_WARN arch/x86/
> arch/x86/configs/i386_defconfig:291:CONFIG_FRAME_WARN=2048
> 
> which came in with:
> 
> 5cb04df8d3f0 ("x86: defconfig updates")
> 
> and OTOH:
> 
> config FRAME_WARN
>         int "Warn for stack frames larger than (needs gcc 4.4)"
>         range 0 8192
>         default 0 if KASAN
>         default 1024 if !64BIT
> 		^^^^
> 
>         default 2048 if 64BIT
>         help
>           Tell gcc to warn at build time for stack frames larger than this.
>           Setting this too low will cause a lot of warnings.
>           Setting it to 0 disables the warning.
>           Requires gcc 4.4
> 
> which is still 1024.
> 
> tip guys, maybe it is time to update lib/Kconfig.debug too?

I think we should rather update the 32-bit defconfig? 64-bit stacks are more 
generous, and a 2K stack footprint is pretty extreme on 32-bit I think ...

Thanks,

	Ingo