From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932532AbcCIMql (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Mar 2016 07:46:41 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35506 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932075AbcCIMqb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Mar 2016 07:46:31 -0500
Date: Wed, 9 Mar 2016 13:46:26 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Leonid Shatz <leonid.shatz@ravellosystems.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86/fpu: Revert earlier patch of Disable AVX when
 eagerfpu is off
Message-ID: <20160309124626.GA28660@gmail.com>
References: <1453511438-25827-1-git-send-email-yu-cheng.yu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453511438-25827-1-git-send-email-yu-cheng.yu@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:

> AVX was mistakenly believed to be dependent on eagerfpu switch.
> This turns out to be false. The earlier patch should be reverted.
> 
> Original patch:
>     http://git.kernel.org/tip/394db20ca240741a08d472173db13d6f6a6e5a28

So the original patch had a whole host of explanations of why that change is 
correct. This revert should explain where that argumentation was wrong.

Also note that eagerfpu=off is on the way out, on v4.6 we'll switch all CPUs to 
eagerfpu:

  58122bf1d856 x86/fpu: Default eagerfpu=on on all CPUs

and in the not so distant future, if everything goes fine with the eager mode, I'd 
like to drop the lazy FPU context switching code altogether - which will simplify 
a lot of code. At that point the 'eagerfpu' boot option will go away as well.

Thanks,

	Ingo