From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935381AbcCKIjy (ORCPT ); Fri, 11 Mar 2016 03:39:54 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34396 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934867AbcCKIjn (ORCPT ); Fri, 11 Mar 2016 03:39:43 -0500 Date: Fri, 11 Mar 2016 15:39:37 +0700 From: Lee Jones To: Laxman Dewangan Cc: Rhyland Klein , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes Message-ID: <20160310020439.GR13692@x1> References: <1455821558-28493-1-git-send-email-rklein@nvidia.com> <20160219085019.GA3410@x1> <56C742C4.4080308@nvidia.com> <56D07ED6.7030607@nvidia.com> <56D43BE1.1080501@nvidia.com> <20160302130828.GB3444@x1> <56E023B2.5020207@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56E023B2.5020207@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Mar 2016, Laxman Dewangan wrote: > On Wednesday 02 March 2016 06:38 PM, Lee Jones wrote: > >On Mon, 29 Feb 2016, Laxman Dewangan wrote: > > > >>On Friday 26 February 2016 10:05 PM, Rhyland Klein wrote: > >>>Did you not see warnings like this when you compiled the kernel? Did you > >>>find a different approach than what I proposed above to deal with it? > >>>I'd like to get this in soon so that when the max77620 drivers are all > >>>in and using it, it should be functional. > >>> > >>I think the following change also crash in runtime: > >> > >>/*** > >>commit e60a946f05db2cac857025da6ffb72df48d3be54 > >>Author: Lee Jones > >> > >> mfd: ab8500: Provide a small example using new MFD cell MACROs > >> > >>***/ > >> > >>Should we have something MFD_CELL_RES, MFD_CELL_RES_PDATA, > >>MFD_CELL_PDATA, for more common user and not to pass the NULL here. > >I'll have a re-think about this. > > Did you get chance to look into this? Probably, I need to send my > mfd series once this get fixed before that series applied. Nothing is going to happen until v4.6 now. It's too late in the release cycle to be making such a significant addition, and I'd like the change to sit in -next for a good while before going in. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog