From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935280AbcCJJ4R (ORCPT ); Thu, 10 Mar 2016 04:56:17 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33134 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935262AbcCJJ4F (ORCPT ); Thu, 10 Mar 2016 04:56:05 -0500 Date: Thu, 10 Mar 2016 10:56:01 +0100 From: Ingo Molnar To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Waiman Long , Thomas Gleixner Subject: Re: [PATCH 03/11] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Message-ID: <20160310095601.GA9677@gmail.com> References: <1442903021-3893-1-git-send-email-mingo@kernel.org> <1442903021-3893-4-git-send-email-mingo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Lutomirski wrote: > On Fri, Feb 12, 2016 at 11:04 AM, Andy Lutomirski wrote: > > On Mon, Sep 21, 2015 at 11:23 PM, Ingo Molnar wrote: > >> So when memory hotplug removes a piece of physical memory from pagetable > >> mappings, it also frees the underlying PGD entry. > >> > >> This complicates PGD management, so don't do this. We can keep the > >> PGD mapped and the PUD table all clear - it's only a single 4K page > >> per 512 GB of memory hotplugged. > > > > Ressurecting an ancient thread: I want this particular change to make > > it (much) easier to make vmapped stacks work correctly. Could it be > > applied by itself? > > > > It's incomplete. pageattr.c has another instance of the same thing. > I'll see if I can make it work, but I may end up doing something a > little different. If so then mind picking up (and fixing ;-) tip:WIP.x86/mm in its entirety? It's well tested so shouldn't have too many easy to hit bugs. Feel free to rebase and restructure it, it's a WIP tree. I keep getting distracted with other things but I'd hate if this got dropped on the floor. Thanks, Ingo