From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbcCJNzI (ORCPT ); Thu, 10 Mar 2016 08:55:08 -0500 Received: from casper.infradead.org ([85.118.1.10]:34741 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbcCJNzD (ORCPT ); Thu, 10 Mar 2016 08:55:03 -0500 Date: Thu, 10 Mar 2016 14:55:00 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: Remove some superfluous lines Message-ID: <20160310135500.GQ6356@twins.programming.kicks-ass.net> References: <20160310084904.GP6344@twins.programming.kicks-ass.net> <20160310134146.GK3452@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160310134146.GK3452@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2016 at 05:41:46AM -0800, Paul E. McKenney wrote: > On Thu, Mar 10, 2016 at 09:49:04AM +0100, Peter Zijlstra wrote: > > > > I think you'll find this condition is superfluous, as the whole function > > is under #ifdef of that same. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Right you are! It got moved under that #ifdef in the process of merging > the RCU, hotplug, and swait changes, and I failed to notice. Good catch! > > I will apply this to my tree once -rc1 comes out, as it will apply to > -rcu at that point. > > Or maybe we should remove the #ifdef and add IS_ENABLED() to the other > functions under that #ifdef. Thoughts? I'd go with the #ifdef, its the conventional pattern.