From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752720AbcCJPSr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 10:18:47 -0500
Received: from verein.lst.de ([213.95.11.211]:53828 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752157AbcCJPSq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 10:18:46 -0500
Date: Thu, 10 Mar 2016 16:18:44 +0100
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
        linux-block@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/3] block: introduce device_add_disk()
Message-ID: <20160310151844.GA8334@lst.de>
References: <20160225200018.21975.30922.stgit@dwillia2-desk3.amr.corp.intel.com> <20160225200443.21975.77561.stgit@dwillia2-desk3.amr.corp.intel.com> <20160310080940.GA773@lst.de> <CAPcyv4jrWp4BKuSyxarTMy4eeezLTos6-MZMup5b4enKkE4N1w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPcyv4jrWp4BKuSyxarTMy4eeezLTos6-MZMup5b4enKkE4N1w@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 10, 2016 at 07:15:19AM -0800, Dan Williams wrote:
> > How are the callers expected to unwind after already having added the
> > disk?
> 
> True, I overlooked making add_disk() unwind-able, will re-spin...

I think this will take more work than we can finish in the next
days.  It would be good to simply respin it without adding the error
propagation.