From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: checkpatch.pl false positive: FSF mailing address
Date: Thu, 10 Mar 2016 11:00:23 -0800 [thread overview]
Message-ID: <20160310190023.GB2545@google.com> (raw)
Hi Joe,
I found this false positive amusing:
$ curl http://patchwork.ozlabs.org/patch/577786/mbox/ | scripts/checkpatch.pl -
[...]
ERROR: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
#1489: FILE: drivers/mtd/nand/qcom_nandc.c:1335:
+^I^I * write to the free oob area.$
[...]
The patch is:
http://patchwork.ozlabs.org/patch/577786/
[PATCH v8,2/3] mtd: nand: Qualcomm NAND controller driver
and the comment text is:
"For the last codeword, we skip the bbm positions and write to the
free oob area."
which matches on this:
# Check for FSF mailing addresses.
if ($rawline =~ /\bwrite to the Free/i ||
I'm just writing as recommended by the closing text of your tool.
Regards,
Brian
next reply other threads:[~2016-03-10 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:00 Brian Norris [this message]
2016-03-10 19:08 ` checkpatch.pl false positive: FSF mailing address Joe Perches
2016-03-10 19:15 ` Brian Norris
2016-03-10 19:25 ` Joe Perches
2016-03-10 19:28 ` Brian Norris
2016-03-10 19:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310190023.GB2545@google.com \
--to=computersforpeace@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox