From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbcCJTAe (ORCPT ); Thu, 10 Mar 2016 14:00:34 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:32882 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbcCJTA0 (ORCPT ); Thu, 10 Mar 2016 14:00:26 -0500 Date: Thu, 10 Mar 2016 11:00:23 -0800 From: Brian Norris To: Joe Perches Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: checkpatch.pl false positive: FSF mailing address Message-ID: <20160310190023.GB2545@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, I found this false positive amusing: $ curl http://patchwork.ozlabs.org/patch/577786/mbox/ | scripts/checkpatch.pl - [...] ERROR: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. #1489: FILE: drivers/mtd/nand/qcom_nandc.c:1335: +^I^I * write to the free oob area.$ [...] The patch is: http://patchwork.ozlabs.org/patch/577786/ [PATCH v8,2/3] mtd: nand: Qualcomm NAND controller driver and the comment text is: "For the last codeword, we skip the bbm positions and write to the free oob area." which matches on this: # Check for FSF mailing addresses. if ($rawline =~ /\bwrite to the Free/i || I'm just writing as recommended by the closing text of your tool. Regards, Brian