From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v6 08/11] tpm: Driver for supporting multiple emulated TPMs
Date: Fri, 11 Mar 2016 12:20:58 +0200 [thread overview]
Message-ID: <20160311102058.GB10270@intel.com> (raw)
In-Reply-To: <56E1AF9F.3010409@linux.vnet.ibm.com>
On Thu, Mar 10, 2016 at 12:32:15PM -0500, Stefan Berger wrote:
> On 03/10/2016 11:39 AM, Jarkko Sakkinen wrote:
> >+/* above flags */
> >+#define VTPM_FLAG_TPM2 1 /* emulator is TPM 2 */
> >+
> >+/* all supported flags */
> >+#define VTPM_FLAGS_ALL (VTPM_FLAG_TPM2)
> >+
> >+#define VTPM_TPM 0xa0
A better name would be VTPM_IOC_MAGIC. You should also update
Documentation/ioctl/ioctl-number.txt.
> >+
> >+#define VTPM_NEW_DEV _IOW(VTPM_TPM, 0x00, struct vtpm_new_dev)
> >I'd rather use VTPM_IOC_NEW_DEV.
>
> What about the name of the structure ? vtpm_ioc_new_dev?
If I look at other subsystems like drm the common practice is either
name the ioctl as VTPM_NEW_DEV_IOCTL or VTPM_IOC_NEW_DEV and not have
suffix or postfix in the parameter struct. I would just copy that
convention here.
> Stefan
/Jarkko
next prev parent reply other threads:[~2016-03-11 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457545170-30120-1-git-send-email-stefanb@linux.vnet.ibm.com>
2016-03-09 17:39 ` [PATCH v6 08/11] tpm: Driver for supporting multiple emulated TPMs Stefan Berger
2016-03-09 18:01 ` Andy Lutomirski
2016-03-10 2:34 ` Stefan Berger
2016-03-10 2:57 ` Andy Lutomirski
2016-03-10 17:38 ` Stefan Berger
2016-03-10 14:15 ` Jarkko Sakkinen
2016-03-10 16:39 ` Jarkko Sakkinen
2016-03-10 17:30 ` Stefan Berger
2016-03-11 9:50 ` Jarkko Sakkinen
2016-03-10 17:32 ` Stefan Berger
2016-03-11 10:20 ` Jarkko Sakkinen [this message]
2016-03-10 22:12 ` Jason Gunthorpe
2016-03-09 17:39 ` [PATCH v6 09/11] tpm: Initialize TPM and get durations and timeouts Stefan Berger
2016-03-09 17:39 ` [PATCH v6 10/11] tpm: Add documentation for the tpm_vtpm device driver Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311102058.GB10270@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox