* [PATCH] staging: xgifb: Fix comments style in vb_init.c
@ 2016-02-24 4:45 YU Bo
2016-03-11 21:41 ` Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: YU Bo @ 2016-02-24 4:45 UTC (permalink / raw)
To: Patard, Kroah-Hartman, Ravichandran, Sri Nizamkari, tsu.yubo
Cc: devel, linux-kernel
Fix comments to use trailing */ on separate lines.
Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
drivers/staging/xgifb/vb_init.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539b..4cb9ff4 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -354,8 +354,10 @@ static void XGINew_DDR2_DefaultRegister(
{
unsigned long P3d4 = Port, P3c4 = Port - 0x10;
- /* keep following setting sequence, each setting in
- * the same reg insert idle */
+ /*
+ * keep following setting sequence, each setting in
+ * the same reg insert idle
+ */
xgifb_reg_set(P3d4, 0x82, 0x77);
xgifb_reg_set(P3d4, 0x86, 0x00);
xgifb_reg_get(P3d4, 0x86); /* Insert read command for delay */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: xgifb: Fix comments style in vb_init.c
@ 2016-02-24 5:26 YU Bo
0 siblings, 0 replies; 4+ messages in thread
From: YU Bo @ 2016-02-24 5:26 UTC (permalink / raw)
To: Patard, Kroah-Hartman, Ravichandran, Sri Nizamkari, yuzibode
Cc: devel, linux-kernel
Fix comments to use trailing */ on separate lines.
Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
drivers/staging/xgifb/vb_init.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 4cb9ff4..8fc8a95 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -700,13 +700,13 @@ static void XGINew_CheckChannel(struct xgi_hw_device_info *HwDeviceExtension,
xgifb_reg_set(pVBInfo->P3c4, 0x14, 0x51); /* 32Mx16 bit*/
break;
case XG42:
- /*
- XG42 SR14 D[3] Reserve
- D[2] = 1, Dual Channel
- = 0, Single Channel
-
- It's Different from Other XG40 Series.
- */
+ /*
+ * XG42 SR14 D[3] Reserve
+ * D[2] = 1, Dual Channel
+ * = 0, Single Channel
+ *
+ * It's Different from Other XG40 Series.
+ */
if (XGINew_CheckFrequence(pVBInfo) == 1) { /* DDRII, DDR2x */
pVBInfo->ram_bus = 32; /* 32 bits */
pVBInfo->ram_channel = 2; /* 2 Channel */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: xgifb: Fix comments style in vb_init.c
2016-02-24 4:45 [PATCH] staging: xgifb: Fix comments style in vb_init.c YU Bo
@ 2016-03-11 21:41 ` Kroah-Hartman
2016-03-12 7:46 ` YU Bo
0 siblings, 1 reply; 4+ messages in thread
From: Kroah-Hartman @ 2016-03-11 21:41 UTC (permalink / raw)
To: YU Bo; +Cc: Patard, Ravichandran, Sri Nizamkari, devel, linux-kernel
On Tue, Feb 23, 2016 at 11:45:18PM -0500, YU Bo wrote:
> Fix comments to use trailing */ on separate lines.
>
> Signed-off-by: YU BO <tsu.yubo@gmail.com>
You sent me 2 patches that did different things yet had the same
subject line :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: xgifb: Fix comments style in vb_init.c
2016-03-11 21:41 ` Kroah-Hartman
@ 2016-03-12 7:46 ` YU Bo
0 siblings, 0 replies; 4+ messages in thread
From: YU Bo @ 2016-03-12 7:46 UTC (permalink / raw)
To: Kroah-Hartman; +Cc: Patard, Ravichandran, Sri Nizamkari, devel, linux-kernel
On Fri, Mar 11, 2016 at 01:41:40PM -0800, Kroah-Hartman wrote:
>On Tue, Feb 23, 2016 at 11:45:18PM -0500, YU Bo wrote:
>> Fix comments to use trailing */ on separate lines.
>>
>> Signed-off-by: YU BO <tsu.yubo@gmail.com>
>
>You sent me 2 patches that did different things yet had the same
>subject line :(
>
>Please fix up and resend.
Ok.
Thank you very much for your time and patience.
YU Bo
>
>thanks,
>
>greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-12 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 4:45 [PATCH] staging: xgifb: Fix comments style in vb_init.c YU Bo
2016-03-11 21:41 ` Kroah-Hartman
2016-03-12 7:46 ` YU Bo
-- strict thread matches above, loose matches on Subject: below --
2016-02-24 5:26 YU Bo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox