From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH 07/10] staging: lustre: cleanup comment style for lnet selftest
Date: Fri, 11 Mar 2016 22:26:58 -0800 [thread overview]
Message-ID: <20160312062658.GA27424@kroah.com> (raw)
In-Reply-To: <20160312062532.GA20558@kroah.com>
On Fri, Mar 11, 2016 at 10:25:32PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Mar 11, 2016 at 10:24:00PM -0800, Greg Kroah-Hartman wrote:
> > On Sat, Mar 12, 2016 at 01:39:01AM +0000, Dilger, Andreas wrote:
> > > On 2016/03/11, 18:29, "lustre-devel on behalf of James Simmons"
> > > <lustre-devel-bounces@lists.lustre.org on behalf of
> > > jsimmons@infradead.org> wrote:
> > >
> > > >Apply a consistent style for comments in the lnet selftest
> > > >code.
> > > >
> > > >Signed-off-by: James Simmons <jsimmons@infradead.org>
> > > >---
> > > > drivers/staging/lustre/lnet/selftest/brw_test.c | 8 ++--
> > > > drivers/staging/lustre/lnet/selftest/conctl.c | 50
> > > >+++++++++++-----------
> > > > drivers/staging/lustre/lnet/selftest/conrpc.c | 23 +++++-----
> > > > drivers/staging/lustre/lnet/selftest/console.c | 11 +++--
> > > > drivers/staging/lustre/lnet/selftest/framework.c | 20 ++++----
> > > > drivers/staging/lustre/lnet/selftest/ping_test.c | 2 +-
> > > > drivers/staging/lustre/lnet/selftest/rpc.c | 46
> > > >++++++++++----------
> > > > drivers/staging/lustre/lnet/selftest/rpc.h | 2 +-
> > > > drivers/staging/lustre/lnet/selftest/selftest.h | 3 +-
> > > > drivers/staging/lustre/lnet/selftest/timer.c | 6 +-
> > > > 10 files changed, 87 insertions(+), 84 deletions(-)
> > > >
> > > >diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c
> > > >b/drivers/staging/lustre/lnet/selftest/brw_test.c
> > > >index eebc924..6ac4d02 100644
> > > >--- a/drivers/staging/lustre/lnet/selftest/brw_test.c
> > > >+++ b/drivers/staging/lustre/lnet/selftest/brw_test.c
> > > >@@ -86,7 +86,7 @@ brw_client_init(sfw_test_instance_t *tsi)
> > > > opc = breq->blk_opc;
> > > > flags = breq->blk_flags;
> > > > npg = breq->blk_npg;
> > > >- /*
> > > >+ /**
> > > > * NB: this is not going to work for variable page size,
> > > > * but we have to keep it for compatibility
> > > > */
> > >
> > > The "/**" comment opener is only for header comment blocks that
> > > have markup in them. I don't think that is kernel style for
> > > normal multi-line comments in the code.
> >
> > Yes, that is correct. James, can you fix this up and resend this
> > series?
>
> Sorry, I meant the series from this patch onward. I've applied the
> first 6.
Make that just this patch, the ones after this applied just fine.
next prev parent reply other threads:[~2016-03-12 6:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 1:29 [PATCH 00/10] Cleanup and audit of lnet selftest code James Simmons
2016-03-12 1:29 ` [PATCH 01/10] staging: lustre: fix bogus lst errors for lnet selftest James Simmons
2016-03-12 1:29 ` [PATCH 02/10] staging: lustre: remove returns in void function " James Simmons
2016-03-12 1:29 ` [PATCH 03/10] staging: lustre: fix spacing issues checkpatch reported in " James Simmons
2016-03-12 1:29 ` [PATCH 04/10] staging: lustre: remove extra spacing of variable declartions for " James Simmons
2016-03-12 1:29 ` [PATCH 05/10] staging: lustre: remove extra spacing when setting variable " James Simmons
2016-03-12 1:29 ` [PATCH 06/10] staging: lustre: filter remaining extra spacing " James Simmons
2016-03-12 1:29 ` [PATCH 07/10] staging: lustre: cleanup comment style " James Simmons
2016-03-12 1:39 ` [lustre-devel] " Dilger, Andreas
2016-03-12 6:24 ` Greg Kroah-Hartman
2016-03-12 6:25 ` Greg Kroah-Hartman
2016-03-12 6:26 ` Greg Kroah-Hartman [this message]
2016-03-12 1:29 ` [PATCH 08/10] staging: lustre: test for proper errno code in lstcon_rpc_trans_abort James Simmons
2016-03-12 1:29 ` [PATCH 09/10] staging: lustre: report minimum of two buffers for LNet selftest load test James Simmons
2016-03-12 1:29 ` [PATCH 10/10] staging: lustre: fix aligments in lnet selftest James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160312062658.GA27424@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox