From: Kent Overstreet <kent.overstreet@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Ming Lin <mlin@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken
Date: Sat, 12 Mar 2016 00:24:21 -0900 [thread overview]
Message-ID: <20160312092421.GA20839@kmo-pixel> (raw)
In-Reply-To: <CACVXFVOJA7=_1DUQm06Qn79xZMQXLob79egnwzOEfVreN2Uopw@mail.gmail.com>
On Sat, Mar 12, 2016 at 04:49:41PM +0800, Ming Lei wrote:
> On Sat, Mar 12, 2016 at 3:43 PM, Kent Overstreet
> <kent.overstreet@gmail.com> wrote:
> > I don't know exactly how it's broken, but with that patch segment counting is
> > broken - I'm seeing blk_rq_map_sg() overrun the end of the sgtable.
> >
> > I suggest reverting it for 4.5...
>
> Kent, could you share your test case? I'd like to figure out the root cause.
xfstest 036 on bcachefs.
> BTW, I don't object to revert it given it is close to v4.5 release, but I am
> curious how it breaks segment couting.
If you want to debug your version (personally I'd just revert to the simpler
one), I'd start by having your helper use both methods to calculate the last
biovec, and then assert that they're equal.
Also make sure you're testing with a sub-page sized blocksize, if filesystem
blocksize == page size you're not going to be testing the interesting cases
next prev parent reply other threads:[~2016-03-12 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 7:43 e827091cb1 "block: merge: get the 1st and last bvec via helpers" broken Kent Overstreet
2016-03-12 8:04 ` Ming Lin
2016-03-12 8:49 ` Ming Lei
2016-03-12 9:24 ` Kent Overstreet [this message]
2016-03-12 10:36 ` Ming Lei
2016-03-12 12:12 ` Kent Overstreet
2016-03-12 13:33 ` Ming Lei
2016-03-12 13:48 ` Kent Overstreet
2016-03-12 14:02 ` Kent Overstreet
2016-03-12 14:25 ` Ming Lei
2016-03-12 14:36 ` Kent Overstreet
2016-03-12 14:39 ` Ming Lei
2016-03-12 19:51 ` Linus Torvalds
2016-03-12 21:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160312092421.GA20839@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox