From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Kees Cook <keescook@chromium.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] s390: disable postinit-readonly for now
Date: Sat, 12 Mar 2016 12:15:40 +0100 [thread overview]
Message-ID: <20160312111540.GA17395@osiris> (raw)
In-Reply-To: <20160310173144.GA25532@www.outflux.net>
On Thu, Mar 10, 2016 at 09:31:44AM -0800, Kees Cook wrote:
> This is a temporary fix to let lkdtm run again on s390, though it'll
> still fail the ro_after_init tests. Until rodata and ro_after_init
> sections can be split on s390, disable special handling of ro_after_init.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> for -next ...
> ---
> arch/s390/include/asm/cache.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> index 4d7ccac5fd1d..22da3b34c655 100644
> --- a/arch/s390/include/asm/cache.h
> +++ b/arch/s390/include/asm/cache.h
> @@ -15,4 +15,7 @@
>
> #define __read_mostly __attribute__((__section__(".data..read_mostly")))
>
> +/* Read-only memory is marked before mark_rodata_ro() is called. */
> +#define __ro_after_init __read_mostly
> +
> #endif
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
next prev parent reply other threads:[~2016-03-12 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 17:31 [PATCH] s390: disable postinit-readonly for now Kees Cook
2016-03-12 11:15 ` Heiko Carstens [this message]
2016-03-16 19:47 ` Christian Borntraeger
2016-03-17 8:49 ` Heiko Carstens
2016-03-21 19:33 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160312111540.GA17395@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox