From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbcCLLPz (ORCPT ); Sat, 12 Mar 2016 06:15:55 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:41623 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbcCLLPr (ORCPT ); Sat, 12 Mar 2016 06:15:47 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Sat, 12 Mar 2016 12:15:40 +0100 From: Heiko Carstens To: Kees Cook Cc: Martin Schwidefsky , Christian Borntraeger , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH] s390: disable postinit-readonly for now Message-ID: <20160312111540.GA17395@osiris> References: <20160310173144.GA25532@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160310173144.GA25532@www.outflux.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031211-0005-0000-0000-00000AC580FD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2016 at 09:31:44AM -0800, Kees Cook wrote: > This is a temporary fix to let lkdtm run again on s390, though it'll > still fail the ro_after_init tests. Until rodata and ro_after_init > sections can be split on s390, disable special handling of ro_after_init. > > Signed-off-by: Kees Cook > --- > for -next ... > --- > arch/s390/include/asm/cache.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h > index 4d7ccac5fd1d..22da3b34c655 100644 > --- a/arch/s390/include/asm/cache.h > +++ b/arch/s390/include/asm/cache.h > @@ -15,4 +15,7 @@ > > #define __read_mostly __attribute__((__section__(".data..read_mostly"))) > > +/* Read-only memory is marked before mark_rodata_ro() is called. */ > +#define __ro_after_init __read_mostly > + > #endif Acked-by: Heiko Carstens