* [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
@ 2016-03-12 23:44 Nicolas Saenz Julienne
2016-03-13 0:11 ` YU Bo
2016-03-13 0:27 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Saenz Julienne @ 2016-03-12 23:44 UTC (permalink / raw)
To: oliver; +Cc: gregkh, linux-usb, linux-kernel
Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
---
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index fa4e239..9831607 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
{ USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
},
+ { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
+ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
+ },
{ USB_DEVICE(0x0ace, 0x1602), /* ZyDAS 56K USB MODEM */
.driver_info = SINGLE_RX_URB,
},
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
2016-03-12 23:44 [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Nicolas Saenz Julienne
@ 2016-03-13 0:11 ` YU Bo
2016-03-13 0:27 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: YU Bo @ 2016-03-13 0:11 UTC (permalink / raw)
To: Nicolas Saenz Julienne; +Cc: oliver, gregkh, linux-usb, linux-kernel
On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
I think that you should add something in here.Describe your change or
imporvment.
>Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
>---
> drivers/usb/class/cdc-acm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
>index fa4e239..9831607 100644
>--- a/drivers/usb/class/cdc-acm.c
>+++ b/drivers/usb/class/cdc-acm.c
>@@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> },
>+ { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
>+ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
>+ },
> { USB_DEVICE(0x0ace, 0x1602), /* ZyDAS 56K USB MODEM */
> .driver_info = SINGLE_RX_URB,
> },
>--
>2.5.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
2016-03-12 23:44 [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Nicolas Saenz Julienne
2016-03-13 0:11 ` YU Bo
@ 2016-03-13 0:27 ` Greg KH
2016-03-15 0:04 ` Nicolas Saenz Julienne
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2016-03-13 0:27 UTC (permalink / raw)
To: Nicolas Saenz Julienne; +Cc: oliver, linux-usb, linux-kernel
On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
> ---
> drivers/usb/class/cdc-acm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index fa4e239..9831607 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> },
> + { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> + },
Why is this needed? Does the descriptors not properly set the class
device?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
2016-03-13 0:27 ` Greg KH
@ 2016-03-15 0:04 ` Nicolas Saenz Julienne
2016-03-15 8:48 ` Oliver Neukum
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Saenz Julienne @ 2016-03-15 0:04 UTC (permalink / raw)
To: Greg KH; +Cc: oliver, linux-usb, linux-kernel
On Sat, Mar 12, 2016 at 04:27:29PM -0800, Greg KH wrote:
> On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> > Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
> > ---
> > drivers/usb/class/cdc-acm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index fa4e239..9831607 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> > { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> > .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > },
> > + { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> > + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > + },
>
> Why is this needed? Does the descriptors not properly set the class
> device?
>
> thanks,
>
> greg k-h
Hi,
the device is missing all the ACM specific "extra" info on it's interface
descriptor. Which seems be triggering the "Zero length descriptor references"
error during the probe function. Adding the NO_UNION_NORMAL quirk seems to solve
the issue.
As for the class device, it seems to be ok, CDC (0x2).
Nicolas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
2016-03-15 0:04 ` Nicolas Saenz Julienne
@ 2016-03-15 8:48 ` Oliver Neukum
0 siblings, 0 replies; 5+ messages in thread
From: Oliver Neukum @ 2016-03-15 8:48 UTC (permalink / raw)
To: Nicolas Saenz Julienne; +Cc: Greg KH, linux-usb, linux-kernel
On Tue, 2016-03-15 at 00:04 +0000, Nicolas Saenz Julienne wrote:
> Hi,
> the device is missing all the ACM specific "extra" info on it's interface
> descriptor. Which seems be triggering the "Zero length descriptor references"
> error during the probe function. Adding the NO_UNION_NORMAL quirk seems to solve
> the issue.
Could you resubmit with this explanation in the change log?
Then everything will be on record. The patch itself is fine.
Regards
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-15 8:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-12 23:44 [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Nicolas Saenz Julienne
2016-03-13 0:11 ` YU Bo
2016-03-13 0:27 ` Greg KH
2016-03-15 0:04 ` Nicolas Saenz Julienne
2016-03-15 8:48 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).