From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932169AbcCMCIa (ORCPT <rfc822;w@1wt.eu>);
	Sat, 12 Mar 2016 21:08:30 -0500
Received: from mail-pa0-f42.google.com ([209.85.220.42]:34079 "EHLO
	mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753899AbcCMCIG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 12 Mar 2016 21:08:06 -0500
Date: Sat, 12 Mar 2016 17:08:49 -0800
From: Olof Johansson <olof@lixom.net>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>, arm@kernel.org, s.hauer@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        wolfgang.netbal@sigmatek.at, Fabio Estevam <fabio.estevam@nxp.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] bus: imx-weim: Take the 'status' property value into
 account
Message-ID: <20160313010849.GI17502@localhost>
References: <1456142513-12876-1-git-send-email-festevam@gmail.com>
 <20160229033649.GS22051@tiger>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160229033649.GS22051@tiger>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 29, 2016 at 11:36:49AM +0800, Shawn Guo wrote:
> On Mon, Feb 22, 2016 at 09:01:53AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> > 
> > Currently we have an incorrect behaviour when multiple devices
> > are present under the weim node. For example:
> > 
> > &weim {
> > 	...
> > 	status = "okay";
> > 	
> > 	sram@0,0 {
> > 		...
> >         	status = "okay";
> > 	};
> > 
> > 	mram@0,0 {
> > 		...
> >         	status = "disabled";
> >     	};
> > };
> > 
> > In this case only the 'sram' device should be probed and not 'mram'.
> > 
> > However what happens currently is that the status variable is ignored,
> > causing the 'sram' device to be disabled and 'mram' to be enabled.  
> > 
> > Change the weim_parse_dt() function to use
> > for_each_available_child_of_node()so that the devices marked with
> > 'status = disabled' are not probed.
> > 
> > Cc: <stable@vger.kernel.org>
> > Suggested-by: Wolfgang Netbal <wolfgang.netbal@sigmatek.at>
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Acked-by: Shawn Guo <shawnguo@kernel.org>
> 
> Arnd, Olof,
> 
> I do not have any other 'driver' patches queued, so please help directly
> apply this one.  Considering this fixes a real problem, it would be good
> if we can merge this through -rc.  But we understand that it's -rc6 now,
> and this doesn't fix a regression or so-critical issue, so it should be
> fine to queue the patch for the next release as well.

Sorry for the high latency here, I had missed this patch and noticed now when
I did a sweep. I've merged it into next/drivers for 4.6.


-Olof