From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: sboyd@codeaurora.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks
Date: Sun, 13 Mar 2016 06:06:27 -0700 [thread overview]
Message-ID: <20160313130627.GT21240@tuxbot> (raw)
In-Reply-To: <1450182602-6996-3-git-send-email-georgi.djakov@linaro.org>
On Tue 15 Dec 04:30 PST 2015, Georgi Djakov wrote:
[..]
> diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
[..]
> +
> +static struct clk_rpm *apq8064_clks[] = {
> + [QCOM_RPM_PXO_CLK] = &apq8064_pxo,
> + [QCOM_RPM_CXO_CLK] = &apq8064_cxo,
> + [QCOM_RPM_APPS_FABRIC_CLK] = &apq8064_afab_clk,
> + [QCOM_RPM_CFPB_CLK] = &apq8064_cfpb_clk,
> + [QCOM_RPM_DAYTONA_FABRIC_CLK] = &apq8064_daytona_clk,
> + [QCOM_RPM_EBI1_CLK] = &apq8064_ebi1_clk,
> + [QCOM_RPM_MM_FABRIC_CLK] = &apq8064_mmfab_clk,
> + [QCOM_RPM_MMFPB_CLK] = &apq8064_mmfpb_clk,
> + [QCOM_RPM_SYS_FABRIC_CLK] = &apq8064_sfab_clk,
> + [QCOM_RPM_SFPB_CLK] = &apq8064_sfpb_clk,
> + [QCOM_RPM_QDSS_CLK] = &apq8064_qdss_clk,
> +};
> +
I do believe we did discuss this, but fwiw, do we really want the rpm
resource identifiers here? Rather than something clock specific
(from qcom,rpmcc.h)?
Regards,
Bjorn
next prev parent reply other threads:[~2016-03-13 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 12:30 [PATCH v6 0/2] Add initial support for RPM clocks Georgi Djakov
2015-12-15 12:30 ` [PATCH v6 1/2] clk: qcom: Add support for SMD-RPM Clocks Georgi Djakov
2015-12-15 12:30 ` [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks Georgi Djakov
2016-02-12 0:41 ` Stephen Boyd
2016-02-22 15:32 ` Georgi Djakov
2016-03-13 13:06 ` Bjorn Andersson [this message]
2016-03-15 17:16 ` Georgi Djakov
2016-02-12 0:37 ` [PATCH v6 0/2] Add initial support for RPM clocks Stephen Boyd
2016-02-22 15:29 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313130627.GT21240@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).