From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932557AbcCMNGi (ORCPT ); Sun, 13 Mar 2016 09:06:38 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35371 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbcCMNGb (ORCPT ); Sun, 13 Mar 2016 09:06:31 -0400 Date: Sun, 13 Mar 2016 06:06:27 -0700 From: Bjorn Andersson To: Georgi Djakov Cc: sboyd@codeaurora.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks Message-ID: <20160313130627.GT21240@tuxbot> References: <1450182602-6996-1-git-send-email-georgi.djakov@linaro.org> <1450182602-6996-3-git-send-email-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450182602-6996-3-git-send-email-georgi.djakov@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 15 Dec 04:30 PST 2015, Georgi Djakov wrote: [..] > diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c [..] > + > +static struct clk_rpm *apq8064_clks[] = { > + [QCOM_RPM_PXO_CLK] = &apq8064_pxo, > + [QCOM_RPM_CXO_CLK] = &apq8064_cxo, > + [QCOM_RPM_APPS_FABRIC_CLK] = &apq8064_afab_clk, > + [QCOM_RPM_CFPB_CLK] = &apq8064_cfpb_clk, > + [QCOM_RPM_DAYTONA_FABRIC_CLK] = &apq8064_daytona_clk, > + [QCOM_RPM_EBI1_CLK] = &apq8064_ebi1_clk, > + [QCOM_RPM_MM_FABRIC_CLK] = &apq8064_mmfab_clk, > + [QCOM_RPM_MMFPB_CLK] = &apq8064_mmfpb_clk, > + [QCOM_RPM_SYS_FABRIC_CLK] = &apq8064_sfab_clk, > + [QCOM_RPM_SFPB_CLK] = &apq8064_sfpb_clk, > + [QCOM_RPM_QDSS_CLK] = &apq8064_qdss_clk, > +}; > + I do believe we did discuss this, but fwiw, do we really want the rpm resource identifiers here? Rather than something clock specific (from qcom,rpmcc.h)? Regards, Bjorn