From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932874AbcCMVaS (ORCPT ); Sun, 13 Mar 2016 17:30:18 -0400 Received: from imap.thunk.org ([74.207.234.97]:38902 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122AbcCMVaO (ORCPT ); Sun, 13 Mar 2016 17:30:14 -0400 Date: Sun, 13 Mar 2016 17:30:06 -0400 From: "Theodore Ts'o" To: Konstantin Khlebnikov Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dmitry Monakhov , Johannes Weiner , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH RFC] ext4: use __GFP_NOFAIL in ext4_free_blocks() Message-ID: <20160313213006.GG29218@thunk.org> Mail-Followup-To: Theodore Ts'o , Konstantin Khlebnikov , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dmitry Monakhov , Johannes Weiner , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org References: <20160224170912.2195.8153.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160224170912.2195.8153.stgit@buzz> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2016 at 08:09:12PM +0300, Konstantin Khlebnikov wrote: > This might be unexpected but pages allocated for sbi->s_buddy_cache are > charged to current memory cgroup. So, GFP_NOFS allocation could fail if > current task has been killed by OOM or if current memory cgroup has no > free memory left. Block allocator cannot handle such failures here yet. > > Signed-off-by: Konstantin Khlebnikov Thanks, applied. - Ted