From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933199AbcCNA5U (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Mar 2016 20:57:20 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:38652 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932584AbcCNA5L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Mar 2016 20:57:11 -0400
Date: Mon, 14 Mar 2016 00:57:06 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel test robot <ying.huang@linux.intel.com>
Cc: lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!
Message-ID: <20160314005706.GX17997@ZenIV.linux.org.uk>
References: <871t7dhokl.fsf@yhuang-dev.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871t7dhokl.fsf@yhuang-dev.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups
> commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge lookup_fast()")

Could you check if the diff below fixes it?

diff --git a/fs/namei.c b/fs/namei.c
index 35b10fa..428a34f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1563,6 +1563,7 @@ static int lookup_fast(struct nameidata *nd,
 					dput(dentry);
 					return status;
 				}
+				goto l;
 			}
 		}
 		/*
@@ -1590,6 +1591,7 @@ static int lookup_fast(struct nameidata *nd,
 				return status;
 			}
 		}
+l:
 		if (unlikely(d_is_negative(dentry))) {
 			dput(dentry);
 			return -ENOENT;