Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

Rafael J. Wysocki
2016-03-11T13:43:39Z

On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote:
> On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote:
> > > It doesn't seem to do any runtime PM,
> > > I do wonder if pcieport should be doing it's own runtime PM handling,
> > > but that is a
> > > larger task than I'm thinking to tackle here.
> >
> > PCIe ports don't do PM - yet. Mika has posted a series of patches to implement
> > that, however, that are waiting for comments now:
> >
> > https://patchwork.kernel.org/patch/8453311/
> > https://patchwork.kernel.org/patch/8453381/
> > https://patchwork.kernel.org/patch/8453391/
> > https://patchwork.kernel.org/patch/8453411/
> > https://patchwork.kernel.org/patch/8453371/
> > https://patchwork.kernel.org/patch/8453351/
> >
> > > Maybe I should be doing
> > >
> > > pci_set_power_state(pdev->bus->self, PCI_D3cold) ? I'm not really sure.
> >
> > Using pci_set_power_state() would be more appropriate IMO, but you can get
> > to the bridge via dev->parent too, can't you?
> >
> > In any case, it looks like you and Mika need to talk. :-)
>
> When the vga_switcheroo device gets runtime suspended (with the above
> runtime PM patchs for PCIe root ports) the root port should also be
> runtime suspended by the PM core.

Right, after your patches have been applied, the additional handling
won't be needed.

So Dave, maybe you can check if the Mika's patches help?

Thanks,
Rafael