From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934000AbcCNJ5e (ORCPT ); Mon, 14 Mar 2016 05:57:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33971 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933492AbcCNJ52 (ORCPT ); Mon, 14 Mar 2016 05:57:28 -0400 Date: Mon, 14 Mar 2016 10:57:14 +0100 From: Jesper Dangaard Brouer To: Gregory CLEMENT Cc: brouer@redhat.com, "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Thomas Petazzoni , Florian Fainelli , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Nadav Haklai , Marcin Wojtas , Simon Guinot , Russell King - ARM Linux , Willy Tarreau , Timor Kardashov , Dmitri Epshtein , Sebastian Careba Subject: Re: [PATCH v6 net-next 08/10] net: mvneta: bm: add support for hardware buffer management Message-ID: <20160314105714.1e97b4c1@redhat.com> In-Reply-To: <1457944745-7634-9-git-send-email-gregory.clement@free-electrons.com> References: <1457944745-7634-1-git-send-email-gregory.clement@free-electrons.com> <1457944745-7634-9-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Mar 2016 09:39:03 +0100 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index b0ae69f84493..2847c0c291de 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c [...] > -static void *mvneta_frag_alloc(const struct mvneta_port *pp) > +void *mvneta_frag_alloc(unsigned int frag_size) > { > - if (likely(pp->frag_size <= PAGE_SIZE)) > - return netdev_alloc_frag(pp->frag_size); > + if (likely(frag_size <= PAGE_SIZE)) > + return netdev_alloc_frag(frag_size); (I know you are modifying existing code here.) Be aware that there is a significant performance advantage of using napi_alloc_frag() over netdev_alloc_frag(). You obviously can only use the NAPI call, if you indeed are running in NAPI/BH context. > else > - return kmalloc(pp->frag_size, GFP_ATOMIC); > + return kmalloc(frag_size, GFP_ATOMIC); > } > +EXPORT_SYMBOL_GPL(mvneta_frag_alloc); -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer