From: Dan Carpenter <dan.carpenter@oracle.com>
To: Minfei Huang <mnfhuang@gmail.com>
Cc: walter harms <wharms@bfs.de>,
xlpang@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Toshi Kani <toshi.kani@hpe.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] kexec: potetially using uninitialized variable
Date: Mon, 14 Mar 2016 13:58:13 +0300 [thread overview]
Message-ID: <20160314105813.GL5273@mwanda> (raw)
In-Reply-To: <20160311153819.GA14320@mhuang-ThinkPad-T440s>
On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote:
> I think we can modify the logic a bit to make code simple. Thus gcc will
> not complain about any more, and the logic is earier.
This is a Smatch warning, not a GCC warning. If you think the new code
is clearer, that's fine but don't just silence the warning to please
Smatch. I'm pretty sure I can silence this warning in Smatch.
regards,
dan carpenter
next prev parent reply other threads:[~2016-03-14 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 8:07 [patch] kexec: potetially using uninitialized variable Dan Carpenter
2016-03-11 8:52 ` Xunlei Pang
2016-03-11 9:19 ` Dan Carpenter
2016-03-11 9:47 ` walter harms
2016-03-11 15:38 ` Minfei Huang
2016-03-14 10:58 ` Dan Carpenter [this message]
2016-03-14 11:25 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314105813.GL5273@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mnfhuang@gmail.com \
--cc=toshi.kani@hpe.com \
--cc=vgoyal@redhat.com \
--cc=wharms@bfs.de \
--cc=xlpang@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox