From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] Unexport do_machine_check() and machine_check_poll()
Date: Mon, 14 Mar 2016 09:55:17 -0700 [thread overview]
Message-ID: <20160314165517.GA3219@intel.com> (raw)
In-Reply-To: <20160314163854.GG15800@pd.tnic>
On Mon, Mar 14, 2016 at 05:38:54PM +0100, Borislav Petkov wrote:
> Hey Tony,
>
> how about the below, untested change?
>
> Some backporting work to SLE11 got me pondering over why we're exporting
> all those MCA-internal things to modules. Modules don't have any
> business calling those so how about hiding them behind a single point
> mce_call() function which gets a command what to do? This way, we're
> free to change stuff later too, if we decide to do so.
It doesn't seem like a very natural fit ... the three routines
take very different arguments which you bundle into a "void *".
I'm also not sure what we gain. Now we have one, complicated,
exported function that still lets modules do all the things
they could do with the three separate functions. Is there some
benefit to having fewer exports?
What am I missing?
-Tony
next prev parent reply other threads:[~2016-03-14 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 16:38 [RFC PATCH] Unexport do_machine_check() and machine_check_poll() Borislav Petkov
2016-03-14 16:52 ` Borislav Petkov
2016-03-14 16:55 ` Luck, Tony [this message]
2016-03-14 18:08 ` Borislav Petkov
2016-03-14 18:24 ` Luck, Tony
2016-03-14 18:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314165517.GA3219@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox