From: Christoph Hellwig <hch@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Shaohua Li <shli@fb.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] block-dev: checking for NULL instead of IS_ERR()
Date: Tue, 15 Mar 2016 00:26:03 -0700 [thread overview]
Message-ID: <20160315072603.GC11669@infradead.org> (raw)
In-Reply-To: <20160308120546.GB28684@mwanda>
On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote:
> This should be an IS_ERR() check. mount_pseudo() returns error pointers
> and this function should return the error pointer to its caller as well.
>
> Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks fine. Would be much nicer to simply pass possible flags as an
argument to mount_pseudo to avoid this whole dance..
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2016-03-15 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 12:05 [patch] block-dev: checking for NULL instead of IS_ERR() Dan Carpenter
2016-03-15 7:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315072603.GC11669@infradead.org \
--to=hch@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).