From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755734AbcCOH1L (ORCPT ); Tue, 15 Mar 2016 03:27:11 -0400 Received: from [198.137.202.9] ([198.137.202.9]:54212 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcCOH1E (ORCPT ); Tue, 15 Mar 2016 03:27:04 -0400 Date: Tue, 15 Mar 2016 00:26:03 -0700 From: Christoph Hellwig To: Dan Carpenter Cc: Alexander Viro , Shaohua Li , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] block-dev: checking for NULL instead of IS_ERR() Message-ID: <20160315072603.GC11669@infradead.org> References: <20160308120546.GB28684@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160308120546.GB28684@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote: > This should be an IS_ERR() check. mount_pseudo() returns error pointers > and this function should return the error pointer to its caller as well. > > Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support') > Signed-off-by: Dan Carpenter Looks fine. Would be much nicer to simply pass possible flags as an argument to mount_pseudo to avoid this whole dance.. Reviewed-by: Christoph Hellwig