From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934192AbcCOHgQ (ORCPT ); Tue, 15 Mar 2016 03:36:16 -0400 Received: from [198.137.202.9] ([198.137.202.9]:57092 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S933992AbcCOHgL (ORCPT ); Tue, 15 Mar 2016 03:36:11 -0400 Date: Tue, 15 Mar 2016 00:35:22 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: axboe@kernel.dk, torvalds@linux-foundation.org, hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com, linux-api@vger.kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, shane.seymour@hpe.com, bfields@fieldses.org, linux-fsdevel@vger.kernel.org, jlayton@poochiereds.net, akpm@linux-foundation.org Subject: Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT. Message-ID: <20160315073522.GI11669@infradead.org> References: <20160305005556.29738.66782.stgit@birch.djwong.org> <20160305005603.29738.58460.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160305005603.29738.58460.stgit@birch.djwong.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2016 at 04:56:03PM -0800, Darrick J. Wong wrote: > Invalidate the page cache (as a regular O_DIRECT write would do) to avoid > returning stale cache contents at a later time. > > v5: Refactor the 4.4 refactoring of the ioctl code into separate functions. > Split the page invalidation and the new ioctl into separate patches. > > Signed-off-by: Darrick J. Wong Didn't I review this already? If not: Reviewed-by: Christoph Hellwig