From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965331AbcCONWU (ORCPT ); Tue, 15 Mar 2016 09:22:20 -0400 Received: from mail1.windriver.com ([147.11.146.13]:37347 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965244AbcCONWJ (ORCPT ); Tue, 15 Mar 2016 09:22:09 -0400 Date: Tue, 15 Mar 2016 09:20:40 -0400 From: Paul Gortmaker To: Linus Walleij CC: "linux-kernel@vger.kernel.org" , Tomasz Figa , Thomas Abraham , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions Message-ID: <20160315132039.GE23251@windriver.com> References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions] On 15/03/2016 (Tue 09:50) Linus Walleij wrote: > On Mon, Feb 29, 2016 at 9:48 PM, Paul Gortmaker > wrote: > > > Fixups here tend to be more all over the map vs. some of the other > > repeated/systematic ones we've seen elsewhere. > > > > We remove module.h from code that isn't doing anything modular at > > all; if they have __init sections, then replace it with init.h > > > > A couple drivers have module_exit() code that is essentially orphaned, > > and so we remove that. > > > > There are no module_init replacements, so we have no concerns wrt. > > initcall ordering changes as per some of the other cleanups. > > > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > > > We also delete the MODULE_LICENSE tag etc. since all that information > > was (or is now) contained at the top of the file in the comments. > > > > Cc: Tomasz Figa > > Cc: Thomas Abraham > > Cc: Linus Walleij > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > This didn't make it in for v4.6 because noone provided ACKs. > > Please resend the outstanding (rebased) demodularization patches > after v4.6-rc1 and I will merge them no matter if I get ACKs or not, > I will not wait for ACKs any longer than that. Sounds good, will do that in ~2 wks. Thanks, Paul. -- > > Yours, > Linus Walleij