From: Borislav Petkov <bp@alien8.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jgross@suse.com" <jgross@suse.com>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 1/2] x86/mm/pat: Change pat_disable() to emulate PAT table
Date: Tue, 15 Mar 2016 16:47:31 +0100 [thread overview]
Message-ID: <20160315154731.GD4559@pd.tnic> (raw)
In-Reply-To: <1458056595.6393.332.camel@hpe.com>
On Tue, Mar 15, 2016 at 09:43:15AM -0600, Toshi Kani wrote:
> > Please use on init paths boot_cpu_has(X86_FEATURE_PAT) and on fast paths
> > static_cpu_has(X86_FEATURE_PAT). No more of that cpu_has_XXX ugliness.
>
> 'cpu_has_pat' is defined as 'boot_cpu_has(X86_FEATURE_PAT)'. Do you mean
> it should explicitly use 'boot_cpu_has(X86_FEATURE_PAT)'?
No, read what I said.
We use boot_cpu_has(<feature_bit>) on slow paths (i.e., init, bootup,
etc), where speed is not that important. static_cpu_has(<feature_bit>)
is an optimized version which should be used in hot paths.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-03-15 15:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 4:45 [PATCH 0/2] Refactor MTRR and PAT initializations Toshi Kani
2016-03-11 4:45 ` [PATCH 1/2] x86/mm/pat: Change pat_disable() to emulate PAT table Toshi Kani
2016-03-11 9:12 ` Borislav Petkov
2016-03-11 16:27 ` Toshi Kani
2016-03-11 15:54 ` Borislav Petkov
2016-03-11 19:28 ` Toshi Kani
2016-03-12 11:55 ` Borislav Petkov
2016-03-14 21:37 ` Toshi Kani
2016-03-15 11:00 ` Borislav Petkov
2016-03-15 22:02 ` Toshi Kani
2016-03-15 0:29 ` Luis R. Rodriguez
2016-03-15 3:11 ` Toshi Kani
2016-03-15 11:01 ` Borislav Petkov
2016-03-15 15:43 ` Toshi Kani
2016-03-15 15:47 ` Borislav Petkov [this message]
2016-03-15 17:11 ` Toshi Kani
2016-03-15 16:33 ` Borislav Petkov
2016-03-15 21:31 ` Luis R. Rodriguez
2016-03-11 4:45 ` [PATCH 2/2] x86/mtrr: Refactor PAT initialization code Toshi Kani
2016-03-11 9:01 ` Ingo Molnar
2016-03-11 9:13 ` Ingo Molnar
2016-03-11 18:34 ` Toshi Kani
2016-03-12 16:18 ` Ingo Molnar
2016-03-14 19:47 ` Toshi Kani
2016-03-14 22:50 ` Luis R. Rodriguez
2016-03-15 0:37 ` Toshi Kani
2016-03-15 15:56 ` Borislav Petkov
2016-03-16 15:44 ` Joe Lawrence
2016-03-11 9:24 ` Borislav Petkov
2016-03-11 18:57 ` Toshi Kani
2016-03-11 22:17 ` Luis R. Rodriguez
2016-03-11 23:56 ` Toshi Kani
2016-03-11 23:34 ` Luis R. Rodriguez
2016-03-12 1:16 ` Toshi Kani
2016-03-15 0:15 ` Luis R. Rodriguez
2016-03-15 23:48 ` Toshi Kani
2016-03-15 23:29 ` Luis R. Rodriguez
2016-03-17 21:56 ` Toshi Kani
2016-03-18 0:06 ` Luis R. Rodriguez
2016-03-18 21:35 ` Toshi Kani
2016-03-29 17:14 ` Luis R. Rodriguez
2016-03-29 21:46 ` Toshi Kani
2016-03-29 22:12 ` Luis R. Rodriguez
2016-03-30 0:16 ` Toshi Kani
2016-03-29 23:43 ` Luis R. Rodriguez
2016-03-30 1:07 ` Toshi Kani
2016-03-30 0:34 ` Luis R. Rodriguez
2016-04-09 2:04 ` Luis R. Rodriguez
2016-04-11 14:30 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315154731.GD4559@pd.tnic \
--to=bp@alien8.de \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox