From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754542AbcCOVvg (ORCPT ); Tue, 15 Mar 2016 17:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56335 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbcCOVvc (ORCPT ); Tue, 15 Mar 2016 17:51:32 -0400 Date: Tue, 15 Mar 2016 22:51:24 +0100 From: Jiri Olsa To: Steven Rostedt Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events Message-ID: <20160315215124.GA2542@krava.redhat.com> References: <1457556405-27717-1-git-send-email-jolsa@kernel.org> <1457556405-27717-2-git-send-email-jolsa@kernel.org> <20160315160646.6238b4fa@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160315160646.6238b4fa@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2016 at 04:06:46PM -0400, Steven Rostedt wrote: > On Wed, 9 Mar 2016 21:46:41 +0100 > Jiri Olsa wrote: > > > Currently we check sample type for ftrace:function event > > even if it's not created as sampling event. That prevents > > creating ftrace_function event in counting mode. > > > > Making sure we check sample types only for sampling events. > > > > Before: > > $ sudo perf stat -e ftrace:function ls > > ... > > > > Performance counter stats for 'ls': > > > > ftrace:function > > > > 0.001983662 seconds time elapsed > > > > After: > > $ sudo perf stat -e ftrace:function ls > > I'm assuming you gave yourself admin capabilities, and not any normal > user may sample function tracing, right? right ;-) jirka