From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966678AbcCPLtw (ORCPT ); Wed, 16 Mar 2016 07:49:52 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35845 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964895AbcCPLtt (ORCPT ); Wed, 16 Mar 2016 07:49:49 -0400 Date: Wed, 16 Mar 2016 11:49:44 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Message-ID: <20160316114944.GY13692@x1> References: <1458123537-12263-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1458123537-12263-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2016, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > This fixes warning on allyesconfig on ARCH=um: > > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && > DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW > && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && > S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && > RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && > ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) > selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > 1. Remove the comment why HAS_IOMEM dependency was added. > 2. Exdended description. > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones Please take this soon, as it's breaking -next (soon to be Mainline). > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index a9727dab9e72..8ad8f91a72e1 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3 > config PHY_HI6220_USB > tristate "hi6220 USB PHY support" > depends on (ARCH_HISI && ARM64) || COMPILE_TEST > + depends on HAS_IOMEM > select GENERIC_PHY > select MFD_SYSCON > help -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog